style: Apply autoformat to contributing/samples/gepa#4342
style: Apply autoformat to contributing/samples/gepa#4342ftnext wants to merge 2 commits intogoogle:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Summary of ChangesHello @ftnext, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a minor style inconsistency within the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request applies the project's auto-formatting to files under contributing/samples/gepa/. The changes consist of removing extra blank lines between import statements, which aligns the code with the project's established style guidelines as enforced by isort and pyink. This is a good housekeeping change that improves code consistency. The changes are correct and look good to merge.
Run ./autoformat.sh to fix import formatting in: - contributing/samples/gepa/experiment.py - contributing/samples/gepa/run_experiment.py
ade42fa to
78300d3
Compare
|
Hi @ftnext , Thank you for your contribution! We appreciate you taking the time to submit this pull request. Your PR has been received by the team and is currently under review. We will provide feedback as soon as we have an update to share. |
|
Hi @Jacksunwei , can you please review this. LGTM. |
Link to Issue or Description of Change
1. Link to an existing issue (if applicable):
N/A - This is a minor style fix.
2. Or, if no issue exists, describe the change:
Problem:
Files under
contributing/samples/gepa/do not conform to the project's autoformat style.Running
./autoformat.shmodifies these files, which means they were not properly formatted.Solution:
Apply
isortandpyinkformatting by running./autoformat.sh.This removes extra blank lines between third-party imports and local imports in:
contributing/samples/gepa/experiment.pycontributing/samples/gepa/run_experiment.pyTesting Plan
This is a small style fix (similar to typo fixes), so detailed testing is not required.
Unit Tests:
Manual End-to-End (E2E) Tests:
N/A - No functional changes. Verified by running
./autoformat.shagain with no further modifications.Checklist
Additional context
This ensures that
contributing/samples/gepa/files follow the same formatting standards as the rest of the codebase.