chore: librarian generate pull request: 20260213T153826Z#1165
chore: librarian generate pull request: 20260213T153826Z#1165
Conversation
product-auto-label
bot
added
size: l
Summary of ChangesHello @parthea, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request, automatically generated by the Librarian CLI, significantly enhances the Cloud Firestore Admin client library by introducing new API parameters and improving existing documentation. It provides developers with greater control over Firestore database configurations, including new data access modes, real-time update settings, and the ability to define unique indexes. The changes also refine existing parameter descriptions, particularly those relevant to the Enterprise database edition, and update development environment configurations. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request, generated by the Librarian CLI, introduces several new features to the Firestore Admin API v1. It exposes mongodb_compatible_data_access_mode, realtime_updates_mode, and firestore_data_access_mode on the Database resource, and a unique parameter on Index. The documentation has also been updated to reflect these changes and clarify behavior for the new 'enterprise' database edition. The changes appear to be correctly implemented, including updates to tests to cover the new fields. I have one minor suggestion to improve code quality in a newly added file.
| from typing import MutableMapping, MutableSequence | ||
|
|
There was a problem hiding this comment.
The MutableMapping and MutableSequence imports are unused in this file and can be removed to improve code cleanliness.
| SYSTEM_TEST_EXTERNAL_DEPENDENCIES: List[str] = [ | ||
| "pytest-asyncio==0.21.2", | ||
| "six", | ||
| "pyyaml", |
There was a problem hiding this comment.
This change needs to be restored
| CURRENT_DIRECTORY = pathlib.Path(__file__).parent.absolute() | ||
|
|
||
| nox.options.sessions = [ | ||
| "unit-3.9", |
1 participant
PR created by the Librarian CLI to generate Cloud Client Libraries code from protos.
BEGIN_COMMIT
BEGIN_NESTED_COMMIT
feat: Expose the
Database.mongodb_compatible_data_access_modeparameterPiperOrigin-RevId: 865444806
Library-IDs: google-cloud-firestore
Source-link: googleapis/googleapis@760ef858
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: Expose the
Database.realtime_updates_modeparameterPiperOrigin-RevId: 865444806
Library-IDs: google-cloud-firestore
Source-link: googleapis/googleapis@760ef858
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: Expose the
Index.uniqueparameterPiperOrigin-RevId: 865444806
Library-IDs: google-cloud-firestore
Source-link: googleapis/googleapis@760ef858
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
docs: Update documentation on several parameters, especially when relating to the new
enterprisedatabase editionPiperOrigin-RevId: 865444806
Library-IDs: google-cloud-firestore
Source-link: googleapis/googleapis@760ef858
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: Expose the
Database.firestore_data_access_modeparameterPiperOrigin-RevId: 865444806
Library-IDs: google-cloud-firestore
Source-link: googleapis/googleapis@760ef858
END_NESTED_COMMIT
END_COMMIT
This pull request is generated with proto changes between
googleapis/googleapis@1a9d00be
(exclusive) and
googleapis/googleapis@760ef858
(inclusive).
Librarian Version: v0.7.0
Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:b8058df4c45e9a6e07f6b4d65b458d0d059241dd34c814f151c8bf6b89211209