Skip to content

chore: librarian generate pull request: 20260213T191645Z#1168

Merged
parthea merged 1 commit intomainfrom
librarian-20260213T191645Z
Feb 13, 2026
Merged

chore: librarian generate pull request: 20260213T191645Z#1168
parthea merged 1 commit intomainfrom
librarian-20260213T191645Z

Conversation

@parthea
Copy link
Contributor

@parthea parthea commented Feb 13, 2026

PR created by the Librarian CLI to generate Cloud Client Libraries code from protos.

BEGIN_COMMIT

BEGIN_NESTED_COMMIT
feat: Expose the Database.firestore_data_access_mode parameter

PiperOrigin-RevId: 865444806
Library-IDs: google-cloud-firestore
Source-link: googleapis/googleapis@760ef858
END_NESTED_COMMIT

BEGIN_NESTED_COMMIT
feat: Expose the Database.mongodb_compatible_data_access_mode parameter

PiperOrigin-RevId: 865444806
Library-IDs: google-cloud-firestore
Source-link: googleapis/googleapis@760ef858
END_NESTED_COMMIT

BEGIN_NESTED_COMMIT
feat: Expose the Database.realtime_updates_mode parameter

PiperOrigin-RevId: 865444806
Library-IDs: google-cloud-firestore
Source-link: googleapis/googleapis@760ef858
END_NESTED_COMMIT

BEGIN_NESTED_COMMIT
feat: Expose the Index.unique parameter

PiperOrigin-RevId: 865444806
Library-IDs: google-cloud-firestore
Source-link: googleapis/googleapis@760ef858
END_NESTED_COMMIT

BEGIN_NESTED_COMMIT
docs: Update documentation on several parameters, especially when relating to the new enterprise database edition

PiperOrigin-RevId: 865444806
Library-IDs: google-cloud-firestore
Source-link: googleapis/googleapis@760ef858
END_NESTED_COMMIT

END_COMMIT

This pull request is generated with proto changes between
googleapis/googleapis@1a9d00be
(exclusive) and
googleapis/googleapis@760ef858
(inclusive).

Librarian Version: v0.7.0
Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:b8058df4c45e9a6e07f6b4d65b458d0d059241dd34c814f151c8bf6b89211209

@parthea parthea requested review from a team as code owners February 13, 2026 19:16
@product-auto-label product-auto-label bot added size: l Pull request size is large. api: firestore Issues related to the googleapis/python-firestore API. labels Feb 13, 2026
@gemini-code-assist
Copy link

Summary of Changes

Hello @parthea, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request integrates several new configuration options for Firestore databases and indexes, primarily to support features associated with the 'Enterprise' database edition. It exposes new parameters for controlling data access modes, real-time updates, and unique index capabilities, accompanied by comprehensive documentation updates to accurately reflect these new features and clarify existing behaviors.

Highlights

  • New Database Parameters: Added firestore_data_access_mode, mongodb_compatible_data_access_mode, and realtime_updates_mode parameters to the Database resource, allowing more granular control over database behavior.
  • Unique Index Support: Introduced a unique parameter for Index and FlatIndex definitions, enabling the creation of unique indexes in Firestore.
  • Documentation Enhancements: Updated documentation across several parameters, particularly clarifying behaviors and defaults related to the new 'Enterprise' database edition and various data access modes.
  • New Enums: Defined new enums RealtimeUpdatesMode and DataAccessMode to support the new database configuration options.
Changelog
  • .librarian/state.yaml
    • Updated the last_generated_commit hash for the google-cloud-firestore library.
  • google/cloud/firestore_admin_v1/services/firestore_admin/async_client.py
    • Imported realtime_updates types.
    • Updated the docstring for sample_create_database to specify Standard edition behavior.
  • google/cloud/firestore_admin_v1/services/firestore_admin/client.py
    • Imported realtime_updates types.
    • Updated the docstring for sample_create_database to specify Standard edition behavior.
  • google/cloud/firestore_admin_v1/types/init.py
    • Imported and exposed the new RealtimeUpdatesMode enum.
  • google/cloud/firestore_admin_v1/types/database.py
    • Imported realtime_updates.
    • Added realtime_updates_mode, firestore_data_access_mode, and mongodb_compatible_data_access_mode fields to the Database message.
    • Introduced the DataAccessMode enum.
    • Updated docstrings for ConcurrencyMode and EncryptionConfig to reference new database editions and snapshot types.
  • google/cloud/firestore_admin_v1/types/field.py
    • Updated the TtlConfig docstring to include details for Enterprise edition databases.
  • google/cloud/firestore_admin_v1/types/firestore_admin.py
    • Updated docstrings for CreateDatabaseRequest, ExportDocumentsRequest, ImportDocumentsRequest, RestoreDatabaseRequest, and CloneDatabaseRequest to clarify database ID and collection group references, especially for Standard edition.
  • google/cloud/firestore_admin_v1/types/index.py
    • Added a unique boolean field to the Index and FlatIndex messages.
    • Expanded the Density enum docstrings with detailed explanations for Standard and Enterprise editions.
  • google/cloud/firestore_admin_v1/types/realtime_updates.py
    • Added a new file defining the RealtimeUpdatesMode enum.
  • tests/unit/gapic/firestore_admin_v1/test_firestore_admin.py
    • Imported realtime_updates.
    • Updated get_index tests to include assertions and parameters for the new unique field.
    • Updated get_database tests to include assertions and parameters for realtime_updates_mode, firestore_data_access_mode, and mongodb_compatible_data_access_mode.
    • Updated create_index, create_database, and update_database REST call tests to include new parameters.
Activity
  • The pull request was automatically generated by the Librarian CLI.
  • The generation process incorporated several nested commits, including new features for exposing Database and Index parameters, and documentation updates.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request, generated by the Librarian CLI, introduces several new features by exposing parameters like firestore_data_access_mode, mongodb_compatible_data_access_mode, realtime_updates_mode for Databases, and unique for Indexes. The changes also include extensive documentation updates to reflect these new features and clarify existing behavior, particularly around database editions. The changes appear to be well-implemented and include corresponding test updates. I've found one minor typo in a docstring that should be corrected for clarity.

Comment on lines +205 to +206
generate an index entry for this document since ``a``, 'b',
``c``, and ``__name__`` are all present but an index of

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

There's a small typo in the docstring. The field b is enclosed in single quotes ('b') instead of double backticks (b), which is inconsistent with the other fields in the example.

Suggested change
generate an index entry for this document since ``a``, 'b',
``c``, and ``__name__`` are all present but an index of
generate an index entry for this document since ``a``, ``b``,
``c``, and ``__name__`` are all present but an index of

@parthea parthea merged commit e16f3be into main Feb 13, 2026
24 of 25 checks passed
@parthea parthea deleted the librarian-20260213T191645Z branch February 13, 2026 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: firestore Issues related to the googleapis/python-firestore API. size: l Pull request size is large.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants