Skip to content

feat: implement consecutive failures healthcheck #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nest-aka-swan wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: implement consecutive failures healthcheck #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 22 additions & 4 deletions lib/dispatcher.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ interface PDConnection {
primary: boolean;
healthy: boolean;
latency: number;
consecutiveFailures: number;
}

interface PDCheckupResult {
Expand Down Expand Up @@ -69,6 +70,7 @@ export class PGDispatcher {
primary: false,
healthy: false,
latency: Infinity,
consecutiveFailures: 0,
};
});
this.options = options;
Expand Down Expand Up @@ -186,7 +188,7 @@ export class PGDispatcher {
const checkups = this.connections.map((connection) =>
this.checkDatabase(connection).catch((error) => {
this.logger.error({message: 'Unhandled error during database checkup', error});
connection.healthy = false;
this.setConnectionHealth(connection, false);
connection.primary = false;
}),
);
Expand Down Expand Up @@ -241,7 +243,7 @@ export class PGDispatcher {
connection.latency = new Date().getTime() - startTime;

if (checkupResult) {
connection.healthy = checkupResult.pingOk;
this.setConnectionHealth(connection, checkupResult.pingOk);
connection.primary = checkupResult.primary;
} else {
if (connection.latency > this.options.healthcheckTimeout) {
Expand All @@ -256,11 +258,11 @@ export class PGDispatcher {
});
}

connection.healthy = false;
this.setConnectionHealth(connection, false);
connection.primary = false;
}
} catch (error) {
connection.healthy = false;
this.setConnectionHealth(connection, false);
connection.primary = false;
this.logger.error({
message: 'Database checkup failed',
Expand All @@ -274,6 +276,22 @@ export class PGDispatcher {
await Promise.all(this.connections.map((c) => c.knex));
}

private setConnectionHealth(connection: PDConnection, healthy: boolean) {
if (healthy) {
connection.consecutiveFailures = 0;
connection.healthy = true;

return;
}

connection.consecutiveFailures++;

const threshold = this.options.healthcheckConsecutiveFailures;
if (!threshold || connection.consecutiveFailures >= threshold) {
connection.healthy = false;
}
}

private get healthyConnections() {
return this.connections.filter((c) => c.healthy);
}
Expand Down
1 change: 1 addition & 0 deletions lib/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import type {PGDispatcher} from './dispatcher';
export interface PDOptions {
healthcheckInterval: number;
healthcheckTimeout: number;
healthcheckConsecutiveFailures?: number;
suppressStatusLogs: boolean;
beforeTerminate: () => Promise<void>;
}
Expand Down
Loading