Skip to content

Comments

feat(network): support packet capture file creation#2275

Open
cagatay-y wants to merge 2 commits intohermit-os:mainfrom
cagatay-y:feat-pcap
Open

feat(network): support packet capture file creation#2275
cagatay-y wants to merge 2 commits intohermit-os:mainfrom
cagatay-y:feat-pcap

Conversation

@cagatay-y
Copy link
Contributor

@cagatay-y cagatay-y commented Feb 20, 2026

Allows creating packet capture files in the pcap format.

The feature also allows us to get nice graphs by using Wireshark's built-in tools.
1771604408

Most of the network initialization code is the same whether DHCP is
enabled or not. Merge the initialization function for the two cases to
reflect that.
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark Results

Details
Benchmark Current: 2846eb3 Previous: 04ab3e2 Performance Ratio
startup_benchmark Build Time 99.36 s 98.87 s 1.01
startup_benchmark File Size 0.86 MB 0.86 MB 1.00
Startup Time - 1 core 0.94 s (±0.04 s) 0.95 s (±0.03 s) 0.99
Startup Time - 2 cores 0.95 s (±0.03 s) 0.97 s (±0.03 s) 0.99
Startup Time - 4 cores 0.97 s (±0.03 s) 0.96 s (±0.03 s) 1.01
multithreaded_benchmark Build Time 100.82 s 101.80 s 0.99
multithreaded_benchmark File Size 0.96 MB 0.96 MB 1.00
Multithreaded Pi Efficiency - 2 Threads 87.62 % (±9.33 %) 91.38 % (±7.84 %) 0.96
Multithreaded Pi Efficiency - 4 Threads 43.93 % (±2.37 %) 44.41 % (±3.31 %) 0.99
Multithreaded Pi Efficiency - 8 Threads 25.37 % (±1.79 %) 25.72 % (±1.88 %) 0.99
micro_benchmarks Build Time 113.14 s 112.45 s 1.01
micro_benchmarks File Size 0.96 MB 0.96 MB 1.00
Scheduling time - 1 thread 71.18 ticks (±3.84 ticks) 71.54 ticks (±3.61 ticks) 0.99
Scheduling time - 2 threads 39.57 ticks (±4.63 ticks) 39.74 ticks (±4.96 ticks) 1.00
Micro - Time for syscall (getpid) 2.91 ticks (±0.28 ticks) 3.06 ticks (±0.30 ticks) 0.95
Memcpy speed - (built_in) block size 4096 65291.18 MByte/s (±46214.86 MByte/s) 64053.45 MByte/s (±45682.00 MByte/s) 1.02
Memcpy speed - (built_in) block size 1048576 30069.72 MByte/s (±25003.52 MByte/s) 29971.18 MByte/s (±24961.55 MByte/s) 1.00
Memcpy speed - (built_in) block size 16777216 24390.16 MByte/s (±20524.31 MByte/s) 25003.45 MByte/s (±21013.82 MByte/s) 0.98
Memset speed - (built_in) block size 4096 65415.46 MByte/s (±46290.34 MByte/s) 64316.32 MByte/s (±45851.10 MByte/s) 1.02
Memset speed - (built_in) block size 1048576 30842.17 MByte/s (±25431.11 MByte/s) 30752.34 MByte/s (±25389.93 MByte/s) 1.00
Memset speed - (built_in) block size 16777216 25161.25 MByte/s (±21028.05 MByte/s) 25753.82 MByte/s (±21487.22 MByte/s) 0.98
Memcpy speed - (rust) block size 4096 58723.72 MByte/s (±43227.92 MByte/s) 59798.08 MByte/s (±44107.11 MByte/s) 0.98
Memcpy speed - (rust) block size 1048576 30010.73 MByte/s (±24968.99 MByte/s) 29689.71 MByte/s (±24867.97 MByte/s) 1.01
Memcpy speed - (rust) block size 16777216 25421.97 MByte/s (±21382.77 MByte/s) 24799.81 MByte/s (±20847.11 MByte/s) 1.03
Memset speed - (rust) block size 4096 59775.17 MByte/s (±43966.89 MByte/s) 60738.74 MByte/s (±44654.61 MByte/s) 0.98
Memset speed - (rust) block size 1048576 30774.52 MByte/s (±25387.39 MByte/s) 30493.17 MByte/s (±25306.10 MByte/s) 1.01
Memset speed - (rust) block size 16777216 26192.08 MByte/s (±21865.82 MByte/s) 25549.21 MByte/s (±21318.77 MByte/s) 1.03
alloc_benchmarks Build Time 103.81 s 103.81 s 1.00
alloc_benchmarks File Size 0.93 MB 0.93 MB 1.00
Allocations - Allocation success 100.00 % 100.00 % 1
Allocations - Deallocation success 100.00 % 100.00 % 1
Allocations - Pre-fail Allocations 100.00 % 100.00 % 1
Allocations - Average Allocation time 11058.26 Ticks (±139.71 Ticks) 11018.15 Ticks (±189.29 Ticks) 1.00
Allocations - Average Allocation time (no fail) 11058.26 Ticks (±139.71 Ticks) 11018.15 Ticks (±189.29 Ticks) 1.00
Allocations - Average Deallocation time 1159.78 Ticks (±901.18 Ticks) 1054.71 Ticks (±332.39 Ticks) 1.10
mutex_benchmark Build Time 103.09 s 109.97 s 0.94
mutex_benchmark File Size 0.96 MB 0.96 MB 1.00
Mutex Stress Test Average Time per Iteration - 1 Threads 12.76 ns (±0.62 ns) 13.32 ns (±0.68 ns) 0.96
Mutex Stress Test Average Time per Iteration - 2 Threads 15.80 ns (±0.72 ns) 15.94 ns (±0.83 ns) 0.99

This comment was automatically generated by workflow using github-action-benchmark.

Allows creating packet capture files in the pcap format.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants