hex_taball to be able to unpack list of files#95
Closed
RudolfMan wants to merge 2 commits intohexpm:masterfrom
Closed
hex_taball to be able to unpack list of files#95RudolfMan wants to merge 2 commits intohexpm:masterfrom
RudolfMan wants to merge 2 commits intohexpm:masterfrom
Conversation
Moved config option of hex_tarball:unpack to be the fourth argument
Member
|
It looks like we do not need this for hexpm/diff#53. Closing this for now, we can always reopen later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I would like to be able to extract particular file from hex_tarball.. (needed for this hexpm/diff#53)
Introduce second argument that might be a list of filenames and pass it down to
hex_erl_taralong with the list of options in tuple{files, ListOfFiles}or an atomall_files(so that we could defaultunpack/2to it)@ericmj do you think it's possible to move recently introduced last config param from
hex_tarball:unpack/3tohex_param:unpack/4while master is not released yet?Sorry for this late PR (should have done earlier)