Updated the CCSS notebook example based on the new structure#25
Merged
danielletijerina merged 1 commit intomainfrom Mar 25, 2026
Merged
Updated the CCSS notebook example based on the new structure#25danielletijerina merged 1 commit intomainfrom
danielletijerina merged 1 commit intomainfrom
Conversation
danielletijerina
approved these changes
Mar 25, 2026
Collaborator
danielletijerina
left a comment
There was a problem hiding this comment.
Looks great! I like the CCSS photo addition!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regarding Danielle's suggestion on replacing the map plot with the one Amy created, I believe
plot_obs_locations()andplot_sites_within_domain()serve different purposes.plot_obs_locations()creates a static plot of observation locations using model grid indices withimshow()andscatter(). It does not use geographic coordinates or shapefiles, and it saves the output as a figure.plot_sites_within_domain()uses geospatial coordinates, displays site markers over the watershed boundary, adds a basemap, and returns an interactive folium.Map object.Given these differences, I decided to keep
plot_sites_within_domain()for this notebook, but I renamed the function name tomap_sites_within_watershed()to better reflect its purpose.