Conversation
Codecov Report
@@ Coverage Diff @@
## main #147 +/- ##
=========================================
Coverage 81.45% 81.45%
Complexity 230 230
=========================================
Files 28 28
Lines 771 771
Branches 60 60
=========================================
Hits 628 628
Misses 93 93
Partials 50 50
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| hypertrace-documentStore = "0.7.18" | ||
|
|
||
| protoc = "3.21.2" | ||
| grpc = "1.48.0" |
There was a problem hiding this comment.
| grpc = "1.48.0" | |
| grpc = "1.50.0" |
| @@ -0,0 +1,44 @@ | |||
| [versions] | |||
| hypertrace-serviceFramework = "0.1.43" | |||
There was a problem hiding this comment.
might be worth waiting for the couple pending framework prs
There was a problem hiding this comment.
yeah, that was the plan
| hypertrace-grpcUtils = "0.9.0" | ||
| hypertrace-documentStore = "0.7.18" | ||
|
|
||
| protoc = "3.21.2" |
There was a problem hiding this comment.
this is an older version with vulnerabilities. we've been using 3.21.7 (although looks like 3.21.8 is out now)
| protoc = "3.21.2" | ||
| grpc = "1.48.0" | ||
| mockito = "4.8.1" | ||
| jackson = "2.13.4.2" |
There was a problem hiding this comment.
nit: this isn't a full jackson version - jackson hotfixes are inconsistent across modules (i.e. most jackson modules don't have a 2.13.4.2, only a 2.13.4). So it works since we only use databind, but probably just want to inline this version there to avoid a mistake in the future (or rename it specifically jacksonDatabind would be fine too)
| mockito-junit = { module = "org.mockito:mockito-junit-jupiter", version.ref = "mockito" } | ||
|
|
||
| [bundles] | ||
| grpc-api = ["grpc-stub", "grpc-protobuf", "javax-annotation"] |
There was a problem hiding this comment.
grpc-bom got removed, please restore it (and if doing other repos, add it)
There was a problem hiding this comment.
fuller explanation of my thinking behind using the grpc bom here - hypertrace/service-framework#56 (comment)
| typesafe-config = { module = "com.typesafe:config", version = "1.4.2" } | ||
| lombok = { module = "org.projectlombok:lombok", version = "1.18.22" } | ||
| slf4j-api = { module = "org.slf4j:slf4j-api", version = "1.7.32" } | ||
| apache-log4j-slf4jImpl = { module = "org.apache.logging.log4j:log4j-slf4j-impl", version = "2.17.1" } |
There was a problem hiding this comment.
could you do a quick check on version numbers. I think a few of these are outdated - log4j, rxjava and lombok at least
|
Can probably close this :) |
2 participants
No description provided.