Throw when accessing non-draftables in strict mode#715
Open
Gelio wants to merge 5 commits intoimmerjs:mainfrom
Open
Throw when accessing non-draftables in strict mode#715Gelio wants to merge 5 commits intoimmerjs:mainfrom
Gelio wants to merge 5 commits intoimmerjs:mainfrom
Conversation
In strict mode, accessing a non-draftable property will throw One can use the unsafe function to perform such operations Fixes immerjs#686
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit c60c592:
|
Collaborator
|
Really awesome! Thanks for doing this :). Looks really promising, just up front a notif that it will probably take me a while to review 😅 |
Contributor
Author
|
@mweststrate I'm glad you like it! Take your time to review it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This MR attempts to implement the idea from #686
It adds a
strictMode(falseby default, enabled bysetStrictModeor passingstrictModeinImmerconstructor) that makes it so that accessing non-draftable properties will throw an error, unless the access is made in anunsafecallback.Fixes #686
Example
See the tests for more examples
Limitations
I tried to make it as compliant with existing functionalities as possible. I was not able to make it fully ES5-compliant. There are a few tests that fail when strict mode is enabled in
base.jstests.I do not have enough expertise to fully fix them. Suggestions are welcome