Fix cmake on linux for build type mapping check.#839
Open
ZackyLake wants to merge 2 commits intointel:ovep-developfrom
Open
Fix cmake on linux for build type mapping check.#839ZackyLake wants to merge 2 commits intointel:ovep-developfrom
ZackyLake wants to merge 2 commits intointel:ovep-developfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a CMake configuration issue on Linux by switching from checking IMPORTED_IMPLIB (Windows-only) to IMPORTED_LOCATION (cross-platform) for detecting available build configurations. This prevents CMake errors about missing imported library properties on Linux when OpenVINO is built with RelWithDebInfo configuration.
- Changed property check from
IMPORTED_IMPLIB_RELWITHDEBINFOtoIMPORTED_LOCATION_RELWITHDEBINFOfor cross-platform compatibility - Extended the build type mapping to include
openvino::frontend::onnxtarget in addition toopenvino::runtime
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
On Linux, there's no IMPORTED_IMPLIB. cmake-IMPORTED_IMPLIB
So the mapping always happens even if OV is built with RelWithDebInfo.
Should better check IMPORTED_LOCATION cmake-IMPORTED_LOCATION
Motivation and Context
Previously on Linux cmake could complain about
IMPORTED_LOCATION or IMPORTED_IMPLIB not set for imported targetThis patch also apply mapping for
openvino::frontend::onnx.