Add global option to disable automatic controller switching#796
Open
adamrb wants to merge 1 commit intoisXander:multiversion/devfrom
Open
Add global option to disable automatic controller switching#796adamrb wants to merge 1 commit intoisXander:multiversion/devfrom
adamrb wants to merge 1 commit intoisXander:multiversion/devfrom
Conversation
The automatic controller switching behavior (where the active controller switches to whichever last provided input) makes it impossible to run multiple game instances side-by-side with different controllers. This adds a toggleable "Auto-Switch Controllers" option in global settings (default: enabled) that gates the tickInactiveController() loop. When disabled, a "Current Controller" dropdown appears allowing manual controller selection. The dropdown dynamically refreshes on controller hotplug events by rebuilding the settings screen.
isXander
requested changes
Feb 24, 2026
| Minecraft.getInstance().setScreen(createGlobalSettingsScreen(parent)); | ||
| } | ||
| }); | ||
|
|
Owner
There was a problem hiding this comment.
This will cause a memory leak. It's not good to create throw-away event registers. result and parent will now live for the entirety of the game lifecycle
| if (controller.equals(getCurrentController().orElse(null))) continue; | ||
|
|
||
| wrapControllerError( | ||
| () -> tickInactiveController(controller), |
Owner
There was a problem hiding this comment.
Don't agree with how this is done here.
Inactive controllers should still be ticked. Move this if statement within tickInactiveController to stop the switch, not stop ticking completely.
| org.gradle.parallel=true | ||
|
|
||
| modVersion=3.0.0-beta.2 | ||
| modVersion=3.0.0-beta.3 |
Owner
There was a problem hiding this comment.
Please don't bump versions in PRs.
| Codec.list(Codec.STRING).fieldOf("seen_servers").forGetter(GlobalConfig::seenServers), | ||
| Codec.BOOL.fieldOf("show_splitscreen_ad").forGetter(GlobalConfig::showSplitscreenAd) | ||
| Codec.BOOL.fieldOf("show_splitscreen_ad").forGetter(GlobalConfig::showSplitscreenAd), | ||
| Codec.BOOL.optionalFieldOf("auto_switch_controllers", true).forGetter(GlobalConfig::autoSwitchControllers) |
Owner
There was a problem hiding this comment.
DTOs should not have optional fields.
- Defaults for GlobalSettings should exist in
GlobalSettings#<init>. - Config migration should be done within a DataFixer, see
dev.isxander.controlify.dto.dfu.- You will need to a new schema version, and a new fix to add this default.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
The automatic controller switching makes it impossible to run multiple game instances side-by-side with different controllers, since pressing a button on controller B in one instance causes the other instance to also switch to controller B.
Test plan
auto_switch_controllers)