This repository was archived by the owner on May 28, 2018. It is now read-only.
Undertow container implementation#3722
Open
jcomo wants to merge 8 commits intojavaee:masterfrom
jcomo:undertow
Open
Undertow container implementation#3722jcomo wants to merge 8 commits intojavaee:masterfrom jcomo:undertow
jcomo wants to merge 8 commits intojavaee:masterfrom
jcomo:undertow
Conversation
added 8 commits
November 20, 2017 17:24
Author
|
@pavelbucek is this something you would be interested in taking a look at? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the code implementation for #3721. It stemmed from a need on our end, but I decided to push it upstream. I based this implementation off of the other containers, but it would be great to have someone look over it with more context (as this is also my first time contributing to the library) to see if I've missed any key points. I think I followed style for comments, localization, etc. but there was no contributing guide that I can find.
Note that I branched this off of 2.26 since I was having issues getting master building on my machine.
I'm open to discussion about this. I know that this is a large change and might need to be broken down a bit more.