Conversation
Contributor
|
I am a little confused about 2 PRs for the same thing being open at once, also I don't know what this "fixes". |
Collaborator
Author
|
@DerArkeN sorry about this, I hadn't see your PR and drafted this change when I saw a comment from @Lagoja. I'll close this and focus on your PR instead. Also, my description was careless and wrong. What I meant to write was "fixes #2335" which causes github to associate the PR to the issue. I somehow copied your PR and linked to it instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fixes #2341Edit:
fixes #2335 but closed as duplicate to #2341
How was it tested?