feat: Add support for fact-to-fact comparison#2
Merged
Conversation
Implements dynamic fact-to-fact comparison allowing rules to compare two runtime facts instead of comparing a fact to a static value. This enables flexible rule evaluation where comparison values can change based on context. Key changes: - Modified Rule::evaluateCondition() to resolve fact references in value field - Updated Rule::interpretCondition() to display fact-to-fact comparisons - Added comprehensive test coverage with testFactToFactComparison() - Updated README with usage examples and documentation - Created examples/fact-to-fact-comparison.php with real-world scenarios Benefits: - Dynamic thresholds without modifying rule definitions - Runtime flexibility for different scenarios - Support for nested fact paths (e.g., user.age vs requirements.minimumAge) Closes #1 Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements dynamic fact-to-fact comparison allowing rules to compare two runtime facts instead of comparing a fact to a static value. This enables flexible rule evaluation where comparison values can change based on context.
Key changes:
Benefits:
Closes #1
Made-with: Cursor