Conversation
|
ENR changes are probably invalid and not as per EIP-778, the changes were done to achieve interop with zeam and should be reverted and corrected on client implementations end. |
tcoratger
left a comment
tcoratger
left a comment
There was a problem hiding this comment.
This looks good to me, thanks a lot:
-
I think the change for
PRF_BYTES_PER_FEwill break the tests when merging on main with the production keys for test vectors but that is totally fine to me. -
Please can you put nice TODOs on stuffs of ENR that are made for interop but not in line with EIP-778 (it's totally fine for me to merge this like this for interop but I had made sure to use everything from EIP-778 and so that is nice to track things and fix on the client side).
| def udp_port(self) -> Port | None: | ||
| """UDP port for discovery (applies to both unless udp6 is set).""" | ||
| raw = self.get(keys.UDP) | ||
| def quic_port(self) -> Port | None: | ||
| """QUIC port for QUIC connections.""" | ||
| raw = self.get(keys.QUIC) | ||
| return Port(int.from_bytes(raw, "big")) if raw else None | ||
|
|
||
| @property | ||
| def udp6_port(self) -> Port | None: | ||
| """IPv6-specific UDP port. Falls back to udp_port if not set.""" | ||
| raw = self.get(keys.UDP6) | ||
| def quic6_port(self) -> Port | None: | ||
| """IPv6-specific QUIC port.""" | ||
| raw = self.get(keys.QUIC6) |
There was a problem hiding this comment.
We should be keeping udp ports and quic ports no? discv5 doesn't use quic etc
There was a problem hiding this comment.
some clients might choose to multiplex both discv5 and quic on 1 udp port, but that would be an option rather than the rule
3 participants
🗒️ Description
Updates
PRF_BYTES_PER_FEto 16 which fixes the leaf mismatch at the time of verification with signatures generated from keys of lean-sig-clip2p related changes: improved logging, topic name, enr keys, replay buffered events support
I was able to achieve interop between spec-zeam in a 2 node devnet (with justifications, finalizations)
🔗 Related Issues or PRs
✅ Checklist
toxchecks to avoid unnecessary CI fails:uvx tox