Conversation
unleashed
force-pushed
the
amr/multiarch-and-podman-support
branch
3 times, most recently
from
3dd68d1 to
9792612
Compare
Previously the devcontainer build infrastructure would install docker-compose in the container via scripts, but that script ended up requiring global changes to Python code in order to install docker-compose. Now we just install it here to avoid that problem.
This is set to never with podman since I'm still experimenting.
This is useful to avoid locking the cache, which is desirable if using buildah, since it has had bugs around this feature. The tradeoff is that you could potentially find locking issues if running multiple parallel apt commands (such as in CI).
This reverts commit 27ab1a5333cc5c5af743c6878f42da23aa5050bf.
unleashed
force-pushed
the
amr/multiarch-and-podman-support
branch
from
9792612 to
7614164
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds multiple architecture support (only arm64 in addition to x86_64 at this point).
It also adds the option of building the container using podman, with a couple limitations (particularly cannot use shared cache locking mode due to a deadlock issue, and cannot build foreign architecture images unless you set up an emulation layer on your own).
Draft until more testing and validation with the devcontainer is done.