fix(eou): only reset speech/speaking time when no new speech#5083
Open
chenghao-mou wants to merge 1 commit intomainfrom
Open
fix(eou): only reset speech/speaking time when no new speech#5083chenghao-mou wants to merge 1 commit intomainfrom
chenghao-mou wants to merge 1 commit intomainfrom
Conversation
Only resets user speech related timestamps when there is no new speech when committing a turn
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
longcw
approved these changes
Mar 11, 2026
Contributor
longcw
left a comment
longcw
left a comment
There was a problem hiding this comment.
lgtm! one question: any chance the race conditions happen to the _last_final_transcript_time as well?
Member
Author
If there is a new final transcript, we will call the _run_eou_detection, which cancels the old _end_of_turn_task. So it should be fine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only resets user speech-related timestamps when there is no new speech when committing a turn, by comparing the captured
last_speaking_timeand the latestself._last_speaking_time