(WIP) Support for large RPC messages using compression + data streams#1832
Draft
(WIP) Support for large RPC messages using compression + data streams#1832
Conversation
This is so that this client protocol value can be used to know what version of RPC that a remote client supports.
…rotocol "0" for now though
…ed in memory at once
…kas did in the original web example Register a data stream with an attribute, and listen for data streams with that attribute on the other end.
…r rpc calls that take a long time If a RPC call takes a long time and a participant disconnects half way through, just drop the return value.
|
Contributor
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently this prototype does the below:
RPCRequestpath with a payload under 1000 bytesRPCRequestinline (compressedPayload)Also undertakes some signifigant refactoring to move RPC logic out into a
RpcClientManager/RpcServerManager, which given the increase in complexity makes the code a little less fragmented / easier to reason about.Todo