Add buildbot to catch unused variables without assertions #721
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We see a lot of warnings pop-up with a ToT clang toolchain (which is supposed to be warning-free for compiling LLVM sources) with assertions disabled due to local variables being used only in assertions. There does not seem to be existing CI coverage of this configuration since almost every bot seems to build with assertions enabled. While these warnings generally do not result in correctness issues, code generally ends up being cleaner/more clear when they are fixed, and they are low cost to fix. We want to add this configuration to empower LLVM developers to find these issues more easily.
boomanaiden154
requested review from
Sterling-Augustine,
gkistanova,
jyknight and
nigham
Sterling-Augustine
approved these changes
Jan 29, 2026
nigham
approved these changes
Jan 29, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We see a lot of warnings pop-up with a ToT clang toolchain (which is supposed to be warning-free for compiling LLVM sources) with assertions disabled due to local variables being used only in assertions. There does not seem to be existing CI coverage of this configuration since almost every bot seems to build with assertions enabled. While these warnings generally do not result in correctness issues, code generally ends up being cleaner/more clear when they are fixed, and they are low cost to fix. We want to add this configuration to empower LLVM developers to find these issues more easily.