fix: use deterministic hash for ETag generation#569
Open
awanawana wants to merge 1 commit intolong2ice:mainfrom
Open
fix: use deterministic hash for ETag generation#569awanawana wants to merge 1 commit intolong2ice:mainfrom
awanawana wants to merge 1 commit intolong2ice:mainfrom
Conversation
Python's built-in hash() is salted by default (PYTHONHASHSEED), producing different values across processes. This causes ETags to change on service restart or differ between backends behind a load balancer, invalidating the cache unexpectedly. Replace hash() with hashlib.md5() which produces consistent values. MD5 is used for speed since this is for caching, not security. Fixes long2ice#400 Co-Authored-By: Claude Opus 4.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #400
Python's built-in
hash()function is salted by default (viaPYTHONHASHSEED), which means it produces different values:This causes ETags to change unexpectedly, invalidating browser caches and making the cache mechanism effectively useless in distributed deployments.
Changes
Replace
hash()withhashlib.md5()for ETag generation:MD5 is chosen for speed since this is for caching (not security). The hash is consistent across processes and restarts.
Before/After
Before (unpredictable across processes):
After (deterministic):
🤖 Generated with Claude Code