Preserve list view state on refresh#98
Open
daewon wants to merge 5 commits intolusingander:masterfrom
Open
Conversation
Restore the active filter and sort selection when reload rebuilds bucket and object list pages. Keep single-bucket reloads retryable until the follow-up object load succeeds.
Expose filter and sort snapshot helpers needed to rebuild bucket and object list pages without losing their current view state.
Owner
|
I commented here as well, it seems generally good, so I'll check it again once you remove the draft status! |
Contributor
Author
|
I added one more small follow-up before taking this out of draft. While reviewing the edge cases again, I noticed that some of the reload completion paths still relied fairly strongly on the current loading model. The normal refresh behavior is unchanged, but I tightened those paths so that unexpected or stale completion state is ignored defensively instead of panicking, and the single-bucket follow-up is checked in release builds as well. I also added tests for those guard paths and re-ran:
I'll remove the draft status now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification