Skip to content

extended DropdownMenuItem and ProductMenuItem interfaces [CLICK-933]#43

Open
LookerClocker wants to merge 16 commits intomasterfrom
CLICL-933
Open

extended DropdownMenuItem and ProductMenuItem interfaces [CLICK-933]#43
LookerClocker wants to merge 16 commits intomasterfrom
CLICL-933

Conversation

@LookerClocker
Copy link
Collaborator

@LookerClocker LookerClocker commented Mar 24, 2026

Summary

Type of Change

  • 🐛 Bug fix
  • ✨ New feature
  • 🔧 Component enhancement
  • 📚 Documentation update
  • 🎨 Style/UI changes
  • ⚙️ Misc

Component(s) Affected

  • New component: ComponentName
  • Modified component: ComponentName
  • Removed component: ComponentName

Changes Made

Testing

  • Unit tests added/updated
  • Storybook stories added/updated
  • Manual testing completed
  • Accessibility testing performed
  • Cross-browser testing (if applicable)
  • Responsive design testing (if applicable)

Storybook

  • New stories created for new components
  • Existing stories updated to reflect changes
  • All component variants documented
  • Props table is accurate and complete
  • Examples demonstrate proper usage

Breaking Changes

Screenshots/Videos

TODO

  • ...

Checklist

  • Code is properly formatted (Prettier/ESLint)
  • All commits are signed
  • TypeScript types are properly defined
  • Components follow design system guidelines
  • Accessibility requirements met (WCAG compliance)
  • Bundle size impact considered
  • Tests included/updated or not needed
  • Storybook stories included/updated or not needed
  • Documentation updated or not required
  • No console errors or warnings
  • Backward compatibility maintained (or breaking changes documented)

@LookerClocker LookerClocker self-assigned this Mar 24, 2026
@LookerClocker LookerClocker changed the title extended BaseProps WIP extended BaseProps [CLICK-933] Mar 24, 2026
@LookerClocker LookerClocker changed the title extended BaseProps [CLICK-933] extended DropdownMenuItem and ProductMenuItem interfaces [CLICK-933] Mar 24, 2026
Copy link
Member

@davidatwhiletrue davidatwhiletrue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LookerClocker see my comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants