Skip to content

Removed unnecessary code to handle start point in lineSliceAlong() #1631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jush wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Removed unnecessary code to handle start point in lineSliceAlong() #1631

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0c353ba
Remove unnecessary code to handle start point in lineSliceAlong()
jush Feb 2, 2026
6c24e12
Added test to verify exact end point in lineSliceAlong
jush Feb 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions services-turf/src/main/java/com/mapbox/turf/TurfMisc.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,13 +205,9 @@ public static LineString lineSliceAlong(@NonNull LineString line,

if (startDist >= travelled && i == coords.size() - 1) {
break;

} else if (travelled > startDist && slice.size() == 0) {
} else if (travelled > startDist && slice.isEmpty()) {
// This logic handles creating the starting point when startDist is not 0 and we passed it.
double overshot = startDist - travelled;
if (overshot == 0) {
slice.add(coords.get(i));
return LineString.fromLngLats(slice);
}
double direction = TurfMeasurement.bearing(coords.get(i), coords.get(i - 1)) - 180;
Point interpolated = TurfMeasurement.destination(coords.get(i), overshot, direction, units);
slice.add(interpolated);
Expand Down
25 changes: 22 additions & 3 deletions services-turf/src/test/java/com/mapbox/turf/TurfMiscTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -490,10 +490,29 @@ public void testLineSliceAlongRoute1() throws IOException, TurfException {

LineString sliced = TurfMisc.lineSliceAlong(route1, start, stop, TurfConstants.UNIT_MILES);

assertEquals(sliced.coordinates().get(0).coordinates(),
start_point.coordinates());
assertEquals(sliced.coordinates().get(0).coordinates(), start_point.coordinates());
assertEquals(sliced.coordinates().get(sliced.coordinates().size() - 1).coordinates(),
end_point.coordinates());
end_point.coordinates());
}

@Test
public void testLineSliceAlongRoute1WithExactStop() throws IOException, TurfException {
Feature route1 = Feature.fromJson(loadJsonFixture(LINE_SLICE_ALONG_ROUTE_ONE));
LineString lineStringRoute1 = (LineString) route1.geometry();

double start = 500;
Point start_point = TurfMeasurement.along(lineStringRoute1, start, TurfConstants.UNIT_MILES);
double exactStop = TurfMeasurement.length(lineStringRoute1, TurfConstants.UNIT_MILES);

LineString slicedAtExactStop = TurfMisc.lineSliceAlong(route1, start, exactStop,
TurfConstants.UNIT_MILES);
List<Point> slicedCoordinatesAtExactStop = slicedAtExactStop.coordinates();
assertEquals(slicedCoordinatesAtExactStop.get(0).coordinates(), start_point.coordinates());
Point lastPointInLine = lineStringRoute1.coordinates().get(
lineStringRoute1.coordinates().size() - 1
);
assertEquals(slicedCoordinatesAtExactStop.get(slicedCoordinatesAtExactStop.size() - 1)
.coordinates(), lastPointInLine.coordinates());
}

@Test
Expand Down