Add a way to display full lyrics in the song details view#31
Open
Ppjet6 wants to merge 2 commits intomarcan:masterfrom
Open
Add a way to display full lyrics in the song details view#31Ppjet6 wants to merge 2 commits intomarcan:masterfrom
Ppjet6 wants to merge 2 commits intomarcan:masterfrom
Conversation
Contributor
|
On refresh, the full lyrics disappear, this should be fixed. Also, ideally it would keep that toggled at least in the (web) session. |
Owner
|
This grew some conflicts due to recent changes, can you take a look at resolving them? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Might be useful to get an idea of the lyrics. All lyrics display can be toggled by clicking on the snippet, maybe the snippet part could be removed when displayed. Comments welcome!