Add possibility to configure http client for oidc-provider#628
Open
ostempel wants to merge 4 commits intomarkbates:masterfrom
Open
Add possibility to configure http client for oidc-provider#628ostempel wants to merge 4 commits intomarkbates:masterfrom
ostempel wants to merge 4 commits intomarkbates:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request refactors the initialization logic for the OpenID Connect provider in
providers/openidConnect/openidConnect.goto reduce code duplication and improve maintainability. The changes introduce a shared helper function for default provider setup and add a new constructor for custom HTTP clients (e.g.: in our development lab we need to skip the TLS verification of our self-sigend certs).Provider initialization refactor:
newBaseProviderto centralize defaultProviderinitialization logic, reducing code duplication across constructors (NewNamed,NewCustomisedURL, etc.).Constructor enhancements:
NewNamedandNewCustomisedURLto usenewBaseProvider, simplifying their code and ensuring consistent initialization.New constructor:
NewCustomisedHttpClientfor custom http-clients