Use maparg to check for previous mappings#52
Open
brookst wants to merge 1 commit intomaxbrunsfeld:masterfrom
Open
Use maparg to check for previous mappings#52brookst wants to merge 1 commit intomaxbrunsfeld:masterfrom
brookst wants to merge 1 commit intomaxbrunsfeld:masterfrom
Conversation
As per issue maxbrunsfeld#12, fail to map using map-<unique> and emit a message directing users to maxbrunsfeld#18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per issue #12, fail to map using map- and emit a message
directing users to #18.
A better solution may be to silently wrap the old mapping but for now this does the right thing and warns the user.