Skip to content

Conversation

@abdulanu0
Copy link
Contributor

  • Add nodejs-claude, python-claude, and nodejs-langchain jobs
  • Add SDK version logging for all samples (Get-SDKVersions.ps1)
  • Add prettified test conversation output (Emit-TestConversations.ps1)
  • Add PR comment with test summary (skips manual/scheduled runs)
  • Update summary job to include all 7 samples with status icons
  • Add pull-requests: write permission for PR comments

@abdulanu0 abdulanu0 requested a review from a team as a code owner January 28, 2026 17:32
Copilot AI review requested due to automatic review settings January 28, 2026 17:32
@github-actions
Copy link

github-actions bot commented Jan 28, 2026

✅ All E2E Tests Passed

Sample Status Result
Python OpenAI success
Node.js OpenAI success
Node.js LangChain success
.NET Semantic Kernel success
.NET Agent Framework success

View full test details

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enhances the E2E testing workflow for Agent 365 samples by adding support for Claude and LangChain integrations, improving observability through SDK version logging, and automating test result reporting via PR comments.

Changes:

  • Added three new E2E test jobs: nodejs-claude, python-claude, and nodejs-langchain
  • Created Get-SDKVersions.ps1 script to log installed SDK package versions across all runtimes
  • Created Emit-TestConversations.ps1 script to format and display test conversation results
  • Enhanced summary job with visual status icons and consolidated reporting
  • Implemented automatic PR commenting with test results (only for pull_request events)
  • Added pull-requests: write permission to enable PR commenting

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 7 comments.

File Description
scripts/e2e/Get-SDKVersions.ps1 New PowerShell script to detect and log SDK versions for Python, Node.js, and .NET projects
scripts/e2e/Emit-TestConversations.ps1 New PowerShell script to format test conversation JSON output into readable console and GitHub summary format
.github/workflows/e2e-agent-samples.yml Added 3 new sample jobs, integrated SDK version logging and test conversation emission across all 7 jobs, enhanced summary with status icons, added PR comment automation, and updated permissions

@rahuldevikar761
Copy link
Collaborator

Can you also screenshot for the local testing for these samples?

- Add nodejs-claude, python-claude, and nodejs-langchain jobs
- Add SDK version logging for all samples (Get-SDKVersions.ps1)
- Add prettified test conversation output (Emit-TestConversations.ps1)
- Add PR comment with test summary (skips manual/scheduled runs)
- Update summary job to include all 7 samples with status icons
- Add pull-requests: write permission for PR comments
@abdulanu0 abdulanu0 force-pushed the users/anabdul/integration_test branch from 87f01f6 to b5dc342 Compare January 28, 2026 18:17
- Fix pipe character escaping in Emit-TestConversations.ps1 (use \\| instead of \|)
- Fix Windows-specific path construction in Get-SDKVersions.ps1 (use nested Join-Path)
- Fix package filtering to exclude A365 packages from Agents SDK list
- Fix bash status icon syntax (use if-else instead of command substitution)
@abdulanu0 abdulanu0 changed the title Add Claude and LangChain samples to E2E workflow LangChain sample to E2E workflow Jan 28, 2026
abdulanu0 and others added 12 commits January 28, 2026 11:27
- Add flexible model configuration that checks for Azure OpenAI first
- Fall back to regular OpenAI if Azure credentials not present
- Update .env.example with both options documented
- Provides clear error message if no credentials found
* fix: Correct YAML syntax in update-e2e-status workflow

* fix: Apply Copilot review suggestions - proper URL encoding, empty string handling, textwrap.dedent, and job count tracking

* Split into multiple workflows

* refactor: Use workflow_call instead of workflow_dispatch for orchestrator - removes need for actions:write permission

* fix: Correct PowerShell parameter names - use -AgentPID instead of -ProcessId, remove invalid -OutputPath and -TestName parameters

* fix: Remove invalid test filter - test names BasicConversation and Notification don't exist

* chore: Remove deprecated monolithic E2E workflow

* chore: Remove deprecated monolithic E2E workflow
- Add LangChain E2E workflow (e2e-nodejs-langchain.yml)
- Add SDK version logging step to all E2E workflows
- Add test conversation emission step to all E2E workflows
- Add PR test summary comment to orchestrator (only on PR events)
- Update orchestrator to include LangChain and add pull-requests: write permission
@abdulanu0 abdulanu0 merged commit a54ffdc into main Jan 30, 2026
30 checks passed
@abdulanu0 abdulanu0 deleted the users/anabdul/integration_test branch January 30, 2026 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants