CSS Typed OM get property return types#1864
Open
ophirbucai wants to merge 9 commits intomicrosoft:mainfrom
Open
CSS Typed OM get property return types#1864ophirbucai wants to merge 9 commits intomicrosoft:mainfrom
ophirbucai wants to merge 9 commits intomicrosoft:mainfrom
Conversation
Narrow down return type of `StylePropertyMapReadOnly.get()` to match CSS Types OM specification. Properties now return their specific CSSStyleValue sub classes: - CSSUnitValue - CSSKeywordValue - CSSTransformValue - Default: CSSStyleValue This change provides better type safety and autocompletion when working with `computedStyleMap()`. Changes: - Added specific return types for common CSS properties in StylePropertyMap - Maintained backwards compatibility with fallback to `CSSStyleValue` - Included links to MDN documentation Tests: - `hereby runtests` completed successfully in the TypeScript repo
Contributor
|
Thanks for the PR! This section of the codebase is owned by @saschanaz - if they write a comment saying "LGTM" then it will be merged. |
…y.get() Move type definitions to overrideTypes to generate corresponding return types, include MDN references Closes microsoft#1863
Author
|
@microsoft-github-policy-service agree |
CSSUnparsedValue for custom properties --* CSSMathValue for properties accepting calc() CSSImageValue for properties accepting url() Separate properties by their return values MDN references for each overloaded function definition
Author
|
I realized that there are more type definitions such as:
The process involved:
Hope it helps people use computedStyleMap(). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Narrow down return type of
StylePropertyMapReadOnly.get()to match CSS Types OM specification. Properties now return their specific CSSStyleValue sub classes:This change provides better type safety and autocompletion when working with
computedStyleMap().Changes:
CSSStyleValue