Unify failure-handling in rewrite-rule

[gramalingam]

Unify failure-handling in rewrite-rule

[codecov]

Codecov Report

❌ Patch coverage is 96.15385% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.93%. Comparing base (19e5284) to head (7385eab).
⚠️ Report is 3 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
onnxscript/rewriter/_rewrite_rule.py	83.33%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2866      +/-   ##
==========================================
+ Coverage   71.86%   71.93%   +0.06%     
==========================================
  Files         239      239              
  Lines       29138    29199      +61     
  Branches     2875     2877       +2     
==========================================
+ Hits        20941    21004      +63     
+ Misses       7219     7217       -2     
  Partials      978      978              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Copilot]

Pull request overview

This PR aims to make rewrite-rule failure signaling consistent with the existing conventions used by check functions, so rule authors can use the same “fail” mechanisms in both phases and get better diagnostics via tracer reporting.

Changes:

• Extend rewrite replacement handling to treat None/False, falsy MatchResult, and MatchFailureError as “rewrite failed” signals.
• Add unit tests covering the supported rewrite failure conventions.
• Update the rewriter tutorial documentation to describe the unified failure conventions for checks and rewrites.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File	Description
onnxscript/rewriter/pattern_base_test.py	Adds tests validating rewrite functions’ supported failure conventions.
onnxscript/rewriter/_rewrite_rule.py	Implements unified failure handling in replacement generation (get_replacement).
docs/tutorial/rewriter/node_value_checkers.md	Documents unified failure conventions for check + rewrite functions.