Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds PHP 8.5 support to the library by updating version constraints and handling the new http_get_last_response_headers() function introduced in PHP 8.4 as a replacement for the deprecated $http_response_header magic variable.
Key Changes:
- Updated PHP version constraint in composer.json to include PHP 8.5
- Added compatibility code for
http_get_last_response_headers()function in StreamClient - Added PHP 8.5 to the GitHub Actions test matrix and updated upload-artifact action to v4
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| composer.json | Updates PHP version constraint to support PHP 8.5 |
| src/Github/Http/StreamClient.php | Adds handling for the new http_get_last_response_headers() function available in PHP 8.4+ |
| .github/workflows/tests.yml | Adds PHP 8.5 to test matrix and upgrades upload-artifact action to v4 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| ], | ||
| "require": { | ||
| "php": ">=8.0 <8.5" | ||
| "php": "8.0 - 8.5" |
There was a problem hiding this comment.
The PHP version constraint syntax "8.0 - 8.5" is not valid Composer syntax. This should be changed to a proper constraint like ">=8.0 <8.6" or "^8.0 || ^8.1 || ^8.2 || ^8.3 || ^8.4 || ^8.5". The hyphen syntax is not recognized by Composer for version ranges.
| "php": "8.0 - 8.5" | |
| "php": ">=8.0 <8.6" |
There was a problem hiding this comment.
|
Thanks |
2 participants
No description provided.