Fix macOS dock tile losing app icon and melt appearing in Dock during export#1807
Fix macOS dock tile losing app icon and melt appearing in Dock during export#1807ddennedy merged 5 commits intomacos-icon-progressfrom
Conversation
Agent-Logs-Url: https://github.com/mltframework/shotcut/sessions/4dfc67a1-016f-4d14-96dc-693fe562b76f Co-authored-by: ddennedy <1146683+ddennedy@users.noreply.github.com>
|
@copilot when doing an export on macOS, a new app icon appears for the background terminal program. How to fix that? |
Agent-Logs-Url: https://github.com/mltframework/shotcut/sessions/ab12618a-4423-4fef-863b-caa79ab49df8 Co-authored-by: ddennedy <1146683+ddennedy@users.noreply.github.com>
Fixed in commit a041908. When |
|
@copilot The export fails on OpenGL when using GPU processing mode. Do not use the offscreen method when GPU processing mode |
… macOS Agent-Logs-Url: https://github.com/mltframework/shotcut/sessions/83ffd684-e01b-4b15-93f2-43da8f2cb077 Co-authored-by: ddennedy <1146683+ddennedy@users.noreply.github.com>
Fixed in commit e6c713a. |
* Fix macOS dock tile losing app icon and melt appearing in Dock during export (#1807) * Prevent melt subprocess from appearing in macOS Dock during export * Skip offscreen Qt platform for melt when GPU processing is enabled on macOS Co-authored-by: Dan Dennedy <dan@dennedy.org> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Setting a custom
NSViewasNSDockTile.contentViewreplaces the system's default rendering, causing the app icon to disappear — leaving only the progress bar on a blank tile. Additionally, whenmeltruns insideShotcut.app/Contents/MacOS/and initializes Qt's Cocoa platform (e.g. for Qt-based MLT filters), Qt registers it as a foreground application, causing a new icon to appear in the Dock during export.Changes
src/macos.mm: IndockProgressBar(), add anNSImageViewbacked byNSApp.applicationIconImageas the base layer of the customcontentViewbefore adding theNSProgressIndicatoron top, so the app icon remains visible while progress is shown.src/jobs/meltjob.cpp: On macOS, setQT_QPA_PLATFORM=offscreeninmelt's process environment so it uses Qt's offscreen backend instead of the Cocoa platform, preventingNSApplicationregistration and keepingmeltinvisible to the Dock. This is skipped when GPU processing mode is enabled (Settings.playerGPU()), since OpenGL requires the Cocoa platform. Note:libqoffscreen.dylibmust be included in the macOS app bundle.All translation updates must go through transifex.com.
Pull requests for those will be rejected.
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.