Skip to content

참여자 선택, 해제 기능 추가 및 참여자 조회 동적 쿼리 추가#30

Merged
sudhdkso merged 4 commits intodevelopfrom
feature/members
Mar 13, 2026
Merged

참여자 선택, 해제 기능 추가 및 참여자 조회 동적 쿼리 추가#30
sudhdkso merged 4 commits intodevelopfrom
feature/members

Conversation

@sudhdkso
Copy link
Contributor

@sudhdkso sudhdkso commented Mar 13, 2026

#️⃣연관된 이슈

x

🔀반영 브랜치

feature/members -> develop

🔧변경 사항

코드에 추가사항 및 변경사항을 작성해주세요.

💬리뷰 요구사항(선택)

리뷰어가 특별히 봐주었으면 하는 부분이 있다면 작성해주세요
ex) 메서드 XXX의 이름을 더 잘 짓고 싶은데 혹시 좋은 명칭이 있을까요

Summary by CodeRabbit

릴리즈 노트

  • New Features

    • 멤버 할당/선택 해제(할당·해제) 엔드포인트 추가
    • 컬렉션 조회 API 추가
  • Improvements

    • 멤버 목록 정렬 옵션 추가(생성일·이름·결제상태)
    • 이미지 URL 처리의 null-safe 개선
    • 멤버 선택 관련 검증·오류 메시지 보강
    • 일부 API 경로/파라미터 표기(code) 정리
  • Documentation

    • API 문서 대규모 보강 및 예제·경로 파라미터 추가

@coderabbitai
Copy link

coderabbitai bot commented Mar 13, 2026

Warning

Rate limit exceeded

@sudhdkso has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 12 minutes and 32 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 80672774-20f3-453e-801b-38c48b146d4e

📥 Commits

Reviewing files that changed from the base of the PR and between fcbc96b and c459880.

📒 Files selected for processing (3)
  • src/test/java/com/dnd/moddo/domain/Member/service/QueryMemberServiceTest.java
  • src/test/java/com/dnd/moddo/domain/Member/service/implementation/MemberReaderTest.java
  • src/test/java/com/dnd/moddo/domain/Member/service/implementation/MemberUpdaterTest.java

Walkthrough

모임원 선택/해제 기능과 멤버 정렬 기능이 추가되고, 내부명 groupTokencode로 일괄 변경되었으며 관련 문서(도감 포함), 쿼리 저장소에 정렬 인수 도입, 예외/도메인/테스트가 확장되었습니다.

Changes

Cohort / File(s) Summary
문서 및 gitignore
\.gitignore, src/docs/asciidoc/index.adoc, src/docs/asciidoc/collection.adoc, src/docs/asciidoc/auth.adoc, src/docs/asciidoc/character.adoc, src/docs/asciidoc/expense.adoc, src/docs/asciidoc/image.adoc, src/docs/asciidoc/member.adoc, src/docs/asciidoc/memberExpenses.adoc, src/docs/asciidoc/settlement.adoc, src/docs/asciidoc/user.adoc
문서 표현 정리·추가(도감 조회), 경로 매개변수 포함, 일부 섹션 제거/정리. .gitignoresrc/main/resources/static/docs/ 추가.
도메인: Member 변화
src/main/java/com/dnd/moddo/event/domain/member/Member.java
assign/unassign 관련 null-check 및 유틸 메서드(isAssigned, isAssignedTo, isInSettlement, getUserId) 추가, unassignUser 구현, paidAt 처리 소폭 정리.
정렬 타입 및 예외들
src/main/java/com/dnd/moddo/event/domain/member/type/MemberSortType.java, src/main/java/com/dnd/moddo/event/domain/member/exception/*
MemberSortType enum(CREATED, NAME, PAID_AT) 추가 및 from 검증, 멤버 선택 관련 예외 6종(예: UserAlreadyAssignedException, MemberAlreadyAssignedException, MemberNotAssignedException, MemberSelectionNotAllowedException, MemberSelectionUnauthorizedException, MemberSortTypeNotFoundException) 추가.
조회/저장소 계층
src/main/java/com/dnd/moddo/event/infrastructure/MemberQueryRepository.java, src/main/java/com/dnd/moddo/event/infrastructure/MemberQueryRepositoryImpl.java, src/main/java/com/dnd/moddo/event/infrastructure/MemberRepository.java, src/main/java/com/dnd/moddo/reward/infrastructure/RewardQueryRepositoryImpl.java
QueryDSL 기반 조회에 정렬 인자 추가 및 동적 정렬(getOrderSpecifiers) 구현, repository 메서드명 변경(findAppointmentMemberIdsBySettlementId → findMemberIdsBySettlementId), existsBySettlementIdAndUserId 추가, 컬렉션 이미지 URL 조건부 프로젝션 적용.
서비스 계층
src/main/java/com/dnd/moddo/event/application/command/CommandMemberService.java, src/main/java/com/dnd/moddo/event/application/impl/MemberUpdater.java, src/main/java/com/dnd/moddo/event/application/impl/MemberReader.java, src/main/java/com/dnd/moddo/event/application/query/QueryMemberService.java, src/main/java/com/dnd/moddo/event/application/impl/SettlementReader.java
assignMember/unassignMember 메서드 추가(유효성·권한 검사 포함), MemberQueryRepository 도입으로 의존성 재구성, 기본 정렬 인자 도입 및 호출 경로 변경.
프레젠테이션 레이어
src/main/java/com/dnd/moddo/event/presentation/MemberController.java, src/main/java/com/dnd/moddo/event/presentation/SettlementController.java, src/main/java/com/dnd/moddo/event/presentation/request/MemberSelectionRequest.java, src/main/java/com/dnd/moddo/event/presentation/response/MemberResponse.java
GET 멤버에 sortType 쿼리파라미터 추가, /assign/unassign 엔드포인트 추가, /{code}/header 매핑 수정, MemberSelectionRequest 레코드 추가, MemberResponse의 userId 매핑 변경 및 JsonInclude 제거.
권한 AOP
src/main/java/com/dnd/moddo/common/support/aop/GroupPermissionAspect.java
groupToken → code로 변수/헬퍼명 변경(extractGroupToken → extractCode) 및 예외 메시지 업데이트(동일 로직, 명칭 변경).
테스트 확장 및 수정
src/test/.../MemberControllerTest.java, .../MemberTest.java, .../CommandMemberServiceTest.java, .../QueryMemberServiceTest.java, .../MemberReaderTest.java, .../MemberUpdaterTest.java, 기타 컨트롤러/서비스 테스트들`
assign/unassign 테스트 추가 및 유효/무효 정렬 타입 검사, REST Docs에 pathParameter 문서화 추가, 다수의 테스트에서 groupTokencode 이름 변경 및 쿼리 정렬 인자 반영, 멤버 도메인 행위 테스트 추가.

Sequence Diagram(s)

sequenceDiagram
    participant Client as Client
    participant Controller as MemberController
    participant CommandService as CommandMemberService
    participant Updater as MemberUpdater
    participant Repo as MemberRepository / MemberQueryRepository
    participant UserRepo as UserRepository

    Client->>Controller: POST /api/v1/groups/{code}/members/assign + body(memberId)
    Controller->>CommandService: assignMember(settlementId, memberId, userId)
    CommandService->>Updater: assignMember(settlementId, memberId, userId)
    Updater->>Repo: existsBySettlementIdAndUserId(settlementId, userId) (validate)
    Updater->>Repo: findById(memberId) / findMemberIdsBySettlementId(...)
    Updater->>UserRepo: findById(userId) (load user)
    Updater->>Repo: save(member) (assign user)
    Updater-->>CommandService: Member
    CommandService-->>Controller: MemberResponse
    Controller-->>Client: 200 OK + MemberResponse
Loading

(다이어그램은 할당 플로우를 단순화하여 주요 컴포넌트 간 시퀀스를 표현합니다.)

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25분

Possibly related PRs

Poem

🐰 새 코드로 껑충, 토끼가 노래하네
작은 버튼 눌러 참여 선택하고 해제해요
이름 대신 이제는 code라 불러요
도감은 반짝, 정렬은 춤추네
축하의 당근 한입, 함께 고고!

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed PR 제목이 변경사항의 주요 내용을 명확하게 요약하고 있습니다. '참여자 선택, 해제 기능 추가 및 참여자 조회 동적 쿼리 추가'는 구체적이고 명확하며, 코드 변경사항의 핵심을 정확히 반영합니다.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feature/members
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link

📝 테스트 커버리지 리포트입니다!

File Coverage [88.95%] 🍏
SettlementReader.java 100% 🍏
Member.java 95.31% 🍏
CommandMemberService.java 92.65% 🍏
MemberUpdater.java 82.33% 🍏
MemberReader.java 76.19%
QueryMemberService.java 64.29%
Total Project Coverage 67.28%

@github-actions
Copy link

📝 테스트 커버리지 리포트입니다!

File Coverage [97.75%] 🍏
SettlementReader.java 100% 🍏
MemberReader.java 100% 🍏
QueryMemberService.java 100% 🍏
MemberUpdater.java 99.53% 🍏
Member.java 95.31% 🍏
CommandMemberService.java 92.65% 🍏
Total Project Coverage 68.65%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant