Add tests to verify McpClient.DisposeAsync doesn't hang#1252
Merged
stephentoub merged 4 commits intomainfrom Feb 13, 2026
Merged
Add tests to verify McpClient.DisposeAsync doesn't hang#1252stephentoub merged 4 commits intomainfrom
stephentoub merged 4 commits intomainfrom
Conversation
stephentoub
reviewed
Feb 6, 2026
tests/ModelContextProtocol.AspNetCore.Tests/MapMcpStreamableHttpTests.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Feb 6, 2026
tests/ModelContextProtocol.AspNetCore.Tests/StreamableHttpClientConformanceTests.cs
Outdated
Show resolved
Hide resolved
stephentoub
previously approved these changes
Feb 6, 2026
Contributor
Contributor
There was a problem hiding this comment.
Pull request overview
Adds regression coverage for issue #1250 to ensure McpClient.DisposeAsync() completes when HttpClientTransportOptions.OwnsSession=false in Streamable HTTP mode, including scenarios with an active GET/SSE stream and unsolicited server notifications.
Changes:
- Added a new conformance test that reproduces an indefinitely-open GET event stream and asserts disposal completes within a bounded time.
- Added two
MapMcpintegration tests assertingDisposeAsyncdoes not hang withOwnsSession=false, including after an unsolicited notification is sent.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| tests/ModelContextProtocol.AspNetCore.Tests/StreamableHttpClientConformanceTests.cs | Adds a regression test simulating an active GET/SSE stream to verify client disposal completes when the client doesn’t own the session. |
| tests/ModelContextProtocol.AspNetCore.Tests/MapMcpStreamableHttpTests.cs | Adds integration tests for MapMcp Streamable HTTP verifying disposal doesn’t hang (with/without unsolicited notifications). |
tests/ModelContextProtocol.AspNetCore.Tests/StreamableHttpClientConformanceTests.cs
Outdated
Show resolved
Hide resolved
tests/ModelContextProtocol.AspNetCore.Tests/StreamableHttpClientConformanceTests.cs
Show resolved
Hide resolved
tests/ModelContextProtocol.AspNetCore.Tests/MapMcpStreamableHttpTests.cs
Outdated
Show resolved
Hide resolved
tests/ModelContextProtocol.AspNetCore.Tests/MapMcpStreamableHttpTests.cs
Show resolved
Hide resolved
tests/ModelContextProtocol.AspNetCore.Tests/MapMcpStreamableHttpTests.cs
Outdated
Show resolved
Hide resolved
tests/ModelContextProtocol.AspNetCore.Tests/StreamableHttpClientConformanceTests.cs
Show resolved
Hide resolved
stephentoub
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add more tests for #1250.