Experimental API routes and server listing API#5162
Draft
Conversation
Contributor
Frontend previewsLast deployed commit is 755fdbbd2fc4081ec5f556127d830378842a657d
|
aecsocket
force-pushed
the
boris/server-listing-api
branch
from
f1c15cf to
e096541
Compare
aecsocket
force-pushed
the
boris/server-listing-api
branch
3 times, most recently
from
b5c9ddb to
45eb02f
Compare
tdgao
reviewed
Feb 10, 2026
aecsocket
force-pushed
the
boris/server-listing-api
branch
2 times, most recently
from
c91f074 to
d01a0fe
Compare
aecsocket
force-pushed
the
boris/server-listing-api
branch
from
392154d to
92a60ff
Compare
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
storybook | 37dc0fe | Commit Preview URL Branch Preview URL |
Feb 23 2026, 10:41 PM |
aecsocket
force-pushed
the
boris/server-listing-api
branch
from
9055fb4 to
1ab3f4c
Compare
fetchfern
requested changes
Feb 23, 2026
Comment on lines
793
to
800
| let mut redis = redis.connect().await?; | ||
| let minecraft_java_server_pings = redis.get_many_deserialized_from_json::<exp::minecraft::JavaServerPing>( | ||
| server_ping::REDIS_NAMESPACE, | ||
| &total_project_ids | ||
| .iter() | ||
| .map(|id| ProjectId::from(*id).to_string()) | ||
| .collect::<Vec<_>>(), | ||
| ) |
Contributor
There was a problem hiding this comment.
Should fallback to ClickHouse
Comment on lines
+127
to
+153
| let row = ServerPingRecord { | ||
| recorded: ping.when.timestamp_nanos_opt().unwrap() | ||
| / 100_000, | ||
| project_id: project_id.0, | ||
| address: ping.address.clone(), | ||
| port: ping.port, | ||
| latency_ms: data.map(|d| d.latency.as_millis() as u32), | ||
| description: data.map(|d| d.description.clone()), | ||
| version_name: data.map(|d| d.version_name.clone()), | ||
| version_protocol: data.map(|d| d.version_protocol), | ||
| players_online: data.map(|d| d.players_online), | ||
| players_max: data.map(|d| d.players_max), | ||
| }; | ||
|
|
||
| ch.write(&row) | ||
| .await | ||
| .wrap_err("failed to write ping record")?; | ||
|
|
||
| redis | ||
| .set_serialized_to_json( | ||
| REDIS_NAMESPACE, | ||
| project_id, | ||
| ping, | ||
| None, | ||
| ) | ||
| .await | ||
| .wrap_err("failed to set redis key")?; |
Contributor
There was a problem hiding this comment.
Should give a little more leeway - dont display server as offline if ping fails once
fetchfern
reviewed
Feb 23, 2026
aecsocket
force-pushed
the
boris/server-listing-api
branch
from
1ab3f4c to
37dc0fe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.