Bug 1897319 - Stores icons for light/dark theme for Yelp suggestion#6248
Closed
dadaa wants to merge 2 commits intomozilla:mainfrom
Closed
Bug 1897319 - Stores icons for light/dark theme for Yelp suggestion#6248dadaa wants to merge 2 commits intomozilla:mainfrom
dadaa wants to merge 2 commits intomozilla:mainfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1897319
Jira: https://mozilla-hub.atlassian.net/browse/SNG-1515
We need to update the UI for Yelp suggestion.
One of them is to chnage the logo. But it has to change by the light/dark theme. Thus, make it to store both icons.
This PR did two things.
Pull Request checklist
[ci full]to the PR title.Branch builds: add
[firefox-android: branch-name]to the PR title.