Skip to content

Bug 1897319 - Stores icons for light/dark theme for Yelp suggestion#6248

Closed
dadaa wants to merge 2 commits intomozilla:mainfrom
dadaa:yelp-theme-icon
Closed

Bug 1897319 - Stores icons for light/dark theme for Yelp suggestion#6248
dadaa wants to merge 2 commits intomozilla:mainfrom
dadaa:yelp-theme-icon

Conversation

@dadaa
Copy link
Contributor

@dadaa dadaa commented May 16, 2024

Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1897319
Jira: https://mozilla-hub.atlassian.net/browse/SNG-1515

We need to update the UI for Yelp suggestion.
One of them is to chnage the logo. But it has to change by the light/dark theme. Thus, make it to store both icons.

This PR did two things.

  1. Stores both icons and change the related codes.
  2. Introduce icon struct as same as PR Bug 1884816 - Expose icon information for suggestion as struct #6162 (A warning that said paramters are too complex in the first commit, it was a good chance :))

Pull Request checklist

  • Breaking changes: This PR follows our breaking change policy
    • This PR follows the breaking change policy:
      • This PR has no breaking API changes, or
      • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due diligence applied in selecting them.

Branch builds: add [firefox-android: branch-name] to the PR title.

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants