Skip to content

AC-93 - Allow embedders to configure context ID rotation period#7262

Merged
Almaju merged 3 commits intomozilla:mainfrom
Almaju:ads-client-configurable-rotation-days-v2
Mar 16, 2026
Merged

AC-93 - Allow embedders to configure context ID rotation period#7262
Almaju merged 3 commits intomozilla:mainfrom
Almaju:ads-client-configurable-rotation-days-v2

Conversation

@Almaju
Copy link
Contributor

@Almaju Almaju commented Mar 9, 2026

Add a rotation_days parameter to MozAdsClientBuilder so the embedder (e.g. HNT) can control the context ID rotation period at construction time rather than relying on the hardcoded default of 3 days.

Pull Request checklist

  • Breaking changes: This PR follows our breaking change policy
    • This PR follows the breaking change policy:
      • This PR has no breaking API changes, or
      • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due diligence applied in selecting them.

…ia AdsClient builder

Add a `rotation_days` parameter to `MozAdsClientBuilder` so the embedder
(e.g. HNT) can control the context ID rotation period at construction time
rather than relying on the hardcoded default of 3 days.
@Almaju Almaju marked this pull request as ready for review March 9, 2026 18:45
@Almaju Almaju changed the title Bug AC-93 - Allow embedders to configure context ID rotation period v… Bug AC-93 - Allow embedders to configure context ID rotation period Mar 9, 2026
@Almaju Almaju changed the title Bug AC-93 - Allow embedders to configure context ID rotation period AC-93 - Allow embedders to configure context ID rotation period Mar 9, 2026
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@Almaju Almaju enabled auto-merge March 12, 2026 19:12
@Almaju Almaju added this pull request to the merge queue Mar 16, 2026
Merged via the queue into mozilla:main with commit aac4226 Mar 16, 2026
13 checks passed
@Almaju Almaju deleted the ads-client-configurable-rotation-days-v2 branch March 16, 2026 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants