fix: correct parameter order in function call#227
Open
sascha-kaleidoscode wants to merge 1 commit intonativewind:mainfrom
Open
fix: correct parameter order in function call#227sascha-kaleidoscode wants to merge 1 commit intonativewind:mainfrom
sascha-kaleidoscode wants to merge 1 commit intonativewind:mainfrom
Conversation
|
It would be great if this got merged, I got stuck on it for an eternity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Correct parameter order in useCssElement call (web)
This fixes a bug in the styled() helper where the arguments to useCssElement were passed in the wrong order. The function expects (component, props, mapping), but we were passing (component, mapping, props) by mistake.
This meant the style mapping was being treated as props, which caused styles to be applied incorrectly. The parameter order is now fixed so everything behaves as intended.