[WIP] Selectbox auto default value

[h4kuna]

• new feature
• BC break? probably no
• doc PR: not need

If you create form with selectbox and render it. Nothing change and submit form, we get first value of items. This unite behavior if you create selectbox and call method getValue() then return first item. It does not matter the order of the called methods. You can see comit named "test".

Example

$form = new Form;
$select = $form->addSelect('foo')
	->setItems(['bar' => 'Bar', 'foo' => 'Foo']);

Old bahavior

Value null is out of range.

$select->getValue() // null

New behavior

$select->getValue() // bar

What do you think?

[dg]

That's fine, I tried something like this.

But beware of that <select size=2> is not submitted with first value.

[h4kuna]

I thinking about one property for value sorted by priority like this:

class NoValue {
// probably it can be singleton :)
}

BaseControl

protected $value = [
    'value' => new NoValue,
    'default' => new NoValue,
    'prompt' => new NoValue,
    'auto' => new NoValue, // defined by input
];

public function setPrompt($value) 
{
$this->value['prompt'] = $value;
}

protected function setValue($value) 
{
...
}

public function setDefaultValue($value) 
{
...
}

public function getValue() 
{
    foreach ($this->value as $value) {
        if (!$value instanceof NoValue) {
            return $value;
        }
    } 
    return null;
}

This implementation is not for this PR.

[f3l1x]

LockAutoDefault looks weird to me.

[h4kuna]

It is little bit complicated, in render time.

Macro input

if i use

{input foo size => 2}

It is compiled

echo end($this->global->formsStack)["foo"]->getControl()->addAttributes(['size' => 2]);

I haven't access to the instance Selectbox. This i can resolve like:

echo end($this->global->formsStack)["foo"]->addAttributes(['size' => 2]);

Html select n: macro

<select n:name="foo" size="2"></select>

Know i value of attribute size in compile time?

<select size="2"<?php
		$_input = end($this->global->formsStack)["foo"];
		echo $_input->getControlPart()->addAttributes(array (
		'size' => NULL,
		))->attributes() ?>><?php echo $_input->getControl()->getHtml() ?></select>

[h4kuna]

I don't know how continue this PR.

Must macros works from template when set up size? If yes, i need help with n:macro and compile time.

@dg wrote anything same, could you paste your resolution or idea?