Skip to content

Active share validation/authoritative mount improvements#57760

Open
icewind1991 wants to merge 22 commits intomasterfrom
share-update-check-single
Open

Active share validation/authoritative mount improvements#57760
icewind1991 wants to merge 22 commits intomasterfrom
share-update-check-single

Conversation

@icewind1991
Copy link
Copy Markdown
Member

@icewind1991 icewind1991 commented Jan 23, 2026 •
edited
Loading

  • For events where we know the share, only check/register mount for that share
  • Above a certain number of users, postpone the checks till fs setup time for the user

@icewind1991 icewind1991 added this to the Nextcloud 34 milestone Jan 23, 2026
@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Jan 23, 2026
@icewind1991 icewind1991 requested a review from a team as a code owner January 23, 2026 15:03
@icewind1991 icewind1991 requested review from Altahrim, ArtificialOwl, nfebe and salmart-dev and removed request for a team January 23, 2026 15:03
@artonge artonge mentioned this pull request Jan 23, 2026
Open
@icewind1991 icewind1991 force-pushed the share-update-check-single branch from b1a28af to 054c5c0 Compare January 23, 2026 15:19
nickvergessen added a commit to nextcloud/spreed that referenced this pull request Jan 23, 2026
@nickvergessen
test: Run tests from nextcloud/server#57760 "fix: only validate mount…
095ab2e 
…s for new share"

Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen added a commit to nextcloud/spreed that referenced this pull request Jan 23, 2026
@nickvergessen
test: Run tests from nextcloud/server#57760 "fix: only validate mount…
46f7a27 
…s for new share"

Signed-off-by: Joas Schilling <coding@schilljs.com>
@icewind1991 icewind1991 force-pushed the share-update-check-single branch from 054c5c0 to 3e548a5 Compare January 23, 2026 15:32
@nickvergessen nickvergessen mentioned this pull request Jan 27, 2026
Closed
@icewind1991 icewind1991 force-pushed the share-update-check-single branch from 3e548a5 to 4851386 Compare February 5, 2026 13:48
nickvergessen added a commit to nextcloud/spreed that referenced this pull request Feb 5, 2026
@nickvergessen
test: Run tests against nextcloud/server#57760 share-update-check-single
4dee540 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen mentioned this pull request Feb 5, 2026
Draft
2 tasks
nickvergessen added a commit to nextcloud/spreed that referenced this pull request Feb 6, 2026
@nickvergessen
test: Run tests against nextcloud/server#57760 share-update-check-single
b303266 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@icewind1991 icewind1991 force-pushed the share-update-check-single branch 2 times, most recently from 000d868 to 716d880 Compare February 9, 2026 15:48
@icewind1991 icewind1991 changed the title fix: only validate mounts for new share Active share validation improvements Feb 12, 2026
@icewind1991 icewind1991 marked this pull request as draft February 12, 2026 14:09
@icewind1991 icewind1991 force-pushed the share-update-check-single branch 2 times, most recently from b35ead2 to 8e50698 Compare February 17, 2026 13:54
@icewind1991 icewind1991 changed the title Active share validation improvements Active share validation/authoritative mount improvements Feb 17, 2026
@icewind1991 icewind1991 force-pushed the share-update-check-single branch 3 times, most recently from f29cc31 to 4b00db9 Compare February 18, 2026 16:00
@icewind1991 icewind1991 force-pushed the share-update-check-single branch 5 times, most recently from 4d56f28 to 5f63dcc Compare March 16, 2026 22:15
@artonge artonge mentioned this pull request Mar 24, 2026
Open
1 task
@icewind1991
fix: only validate mounts for new share
3a7eaf8 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
feat: add event for user home mount having being setup
0c1384e 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
chore: move share recipient validation logic to a separate class
513f718 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
feat: postpone receiving share validation after processing a certain …
2f7851b 
…number of users

Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
test: add test for delayed share validate
a292be9 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
fix: disable share resolve postpone in tests
3520b65 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
feat: export getData for public FileInfo interface
5582a44 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
fix: clear in-memory cached mounts for user when adding/removing mounts
f442170 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
test: add reusable mock implementation for IAppConfig
47930a5 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
test: add reusable mock implementation for IUserConfig
11f743f 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
test: add some tests for SharesUpdatedListenerTest
74436c3 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
test: add some tests for ShareRecipientUpdaterTest
e87e3f2 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
feat: use time-based cutoff for share updating instead of count
fade638 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
fix: improve performance of handling delete shares
9dc56d5 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
feat: add output options and '--cached-only' to list mounts command
6dc5712 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
fix: update shares on group delete
83c86cc 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
test: add more integration tests for share mount handling
84d6889 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
fix: handle share moves
c36cb5e 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
fix: fix moving mountpoints
0755548 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
fix: move mountpoint when transfering share
8f176b4 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
fix: use proper index when deleting mounts
0c19ce0 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 icewind1991 force-pushed the share-update-check-single branch from 5f63dcc to 0c19ce0 Compare March 27, 2026 17:45
@icewind1991
fix: default user_needs_share_refresh to true
a5d2c7e 
Signed-off-by: Robin Appelman <robin@icewind.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@salmart-dev salmart-dev salmart-dev approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl is a code owner automatically assigned from nextcloud/server-backend

@Altahrim Altahrim Awaiting requested review from Altahrim Altahrim is a code owner automatically assigned from nextcloud/server-backend

@nfebe nfebe Awaiting requested review from nfebe nfebe is a code owner automatically assigned from nextcloud/server-backend

@CarlSchwan CarlSchwan Awaiting requested review from CarlSchwan

@artonge artonge Awaiting requested review from artonge

@provokateurin provokateurin Awaiting requested review from provokateurin

Assignees

No one assigned

Labels

3. to review Waiting for reviews

Projects

None yet

Milestone

Nextcloud 34

Development

Successfully merging this pull request may close these issues.

6 participants

@icewind1991 @nickvergessen @salmart-dev @artonge @CarlSchwan @provokateurin