Updating nf-core modules and subworkflows, including preparation for topics#487
Open
Kevin-Brockers wants to merge 38 commits intonf-core:devfrom
Open
Updating nf-core modules and subworkflows, including preparation for topics#487Kevin-Brockers wants to merge 38 commits intonf-core:devfrom
Kevin-Brockers wants to merge 38 commits intonf-core:devfrom
Conversation
…nnels accordingly
|
JoseEspinosa
requested changes
Mar 12, 2026
Member
JoseEspinosa
left a comment
There was a problem hiding this comment.
Very nice job! Only some suggestions
Co-authored-by: Jose Espinosa-Carrasco <[email protected]>
Co-authored-by: Jose Espinosa-Carrasco <[email protected]>
Author
|
Shall I remove all |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
nf-core lint).nextflow run . -profile test,singularity --outdir <OUTDIR>).nextflow run . -profile debug,test,docker --outdir <OUTDIR>).Brief description
Adapted to topics in named workflow: ad9fa86
Updated nf-core modules, see: 2edc288
subworkflows and modules, see: b4b9757
Removed ch_version from subworkflows (local)
Changed
CUSTOM_GETCHROMSIZES to SAMTOOLS_FAIDX, see: 4ddf007a bit back and forth to fix things and run tests on a slurm cluster. I think will be fine if we squash the commits.