Issue #456, set skip_preseq default to true, and updated docs and changelog#488
Issue #456, set skip_preseq default to true, and updated docs and changelog#488Zashraf783 wants to merge 2 commits intonf-core:devfrom
Conversation
This PR is against the
|
JoseEspinosa
left a comment
There was a problem hiding this comment.
Thanks for the contribution!I
The PR should be done against dev as you can see in the branch protection message and your branch should checkout from dev. Also I added some suggestions.
|
|
||
| ### Enhancements & fixes | ||
|
|
||
| - [[#456] (https://github.com/nf-core/chipseq/issues/456)] - Changed default for `--skip_preseq` to `true` (Preseq analysis is now skipped by default). |
There was a problem hiding this comment.
This should be moved under the development version of the pipeline, this enhancements correspond to the released version 2.1.0
nextflow_schema.json
Outdated
| "skip_preseq": { | ||
| "type": "boolean", | ||
| "description": "Skip Preseq.", | ||
| "description": "Skip Preseq (true by default).", |
There was a problem hiding this comment.
| "description": "Skip Preseq (true by default).", | |
| "description": "Skip Preseq.", |
| "type": "boolean", | ||
| "description": "Skip Preseq.", | ||
| "description": "Skip Preseq (true by default).", | ||
| "fa_icon": "fas fa-fast-forward" |
There was a problem hiding this comment.
| "fa_icon": "fas fa-fast-forward" | |
| "fa_icon": "fas fa-fast-forward", | |
| "default": true |
Co-authored-by: Jose Espinosa-Carrasco <kadomu@gmail.com>
PR checklist
nf-core lint).nextflow run . -profile test,docker --outdir <OUTDIR>).nextflow run . -profile debug,test,docker --outdir <OUTDIR>).docs/usage.mdis updated.docs/output.mdis updated.CHANGELOG.mdis updated.README.mdis updated (including new tool citations and authors/contributors).