fix: filter out new keys from legacy JSON generator#595
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #595 +/- ##
==========================================
- Coverage 80.80% 80.57% -0.24%
==========================================
Files 126 126
Lines 12073 12121 +48
Branches 874 874
==========================================
+ Hits 9756 9766 +10
- Misses 2314 2352 +38
Partials 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Removed commented TODO note about additional keys in JSON output.
There was a problem hiding this comment.
Pull request overview
This PR updates the legacy-json generator to emit “legacy-compatible” JSON by filtering the serialized output to a specific allowlist of keys, aiming to prevent newly introduced fields from appearing in generated legacy JSON files.
Changes:
- Replaces
JSON.stringify(section, null, 2)withJSON.stringify(section, [allowedKeys...], 2)to filter output keys. - Conditionally includes the
moduleskey for non-indexsections during serialization.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
| File | Base | Head | Diff |
|---|---|---|---|
orama-db.json |
8.03 MB | 8.03 MB | -3.00 B (-0.00%) |
ovflowd
left a comment
There was a problem hiding this comment.
Let's wait for the TSC meeting.
|
To be clear, not against the PR, just want to want for the TSC meeting before we make any decisions on the approach. |
Description
Validation
Related Issues
Check List
node --run testand all tests passed.node --run format&node --run lint.