test: blindly attempt to re-enable nightly#420
Conversation
I disabled this in nodejs#404. This is a PR so I can futz around with it and try to figure out why the mirror isn't working.
|
It fails with this error: (The warning probably isn't relevant, I think it just needs this patch: diff --git a/action.yml b/action.yml
index e50fa0e..af619f2 100644
--- a/action.yml
+++ b/action.yml
@@ -29,6 +29,8 @@ inputs:
version:
description: 'Deprecated. Use node-version instead. Will not be supported after October 1, 2019'
deprecationMessage: 'The version property will not be supported after October 1, 2019. Use node-version instead'
+ node-mirror:
+ description: 'Optional URL of an alternate Node.js mirror to use. Example: https://nodejs.org/download/nightly/'
outputs:
cache-hit:
description: 'A boolean value to indicate if a cache was hit'but I don't think that it's actually causing the issue? actions/runner#514 looks like the upstream issue about the warning.) |
|
@kvakil This is failing because 19.x doesn't exist in https://nodejs.org/dist/ |
|
@kvakil So this was easy. |
|
Now that 19 is released i re-ran the tests We should probably look at disabling Ubuntu 18 for the 19 tests? |
I disabled this in #404. This is a PR so I can futz around with it and try to figure out why the mirror isn't working.