Draft
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
build
Member
|
Yes |
Qard
reviewed
Mar 2, 2026
Member
Qard
left a comment
Qard
left a comment
There was a problem hiding this comment.
Looks very cool! I'm glad to see someone has picked this back up. 🙂
I did a quick review and it all looks good. My only comment is there seems to be a bunch of static strings and a private symbol which we might want to define in env_properties.h.
Comment on lines
+47
to
+57
| Local<Private> GetPointerAddressPrivate(Isolate* isolate) { | ||
| static Eternal<Private> private_symbol; | ||
| Local<Private> priv = private_symbol.Get(isolate); | ||
| if (priv.IsEmpty()) { | ||
| priv = Private::ForApi( | ||
| isolate, | ||
| String::NewFromUtf8Literal(isolate, "node:ffi:pointer_address")); | ||
| private_symbol.Set(isolate, priv); | ||
| } | ||
| return priv; | ||
| } |
Member
There was a problem hiding this comment.
Should this not be defined in PER_ISOLATE_PRIVATE_SYMBOL_PROPERTIES?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is not ready for review yet. Just opening to see if this is something the project is still interested in.