chore: migrate from middleware.ts to proxy.ts for Next.js 16 compatib… by Faizanahmedsy · Pull Request #8419 · nodejs/nodejs.org

Faizanahmedsy · 2025-12-14T14:00:46Z

…ility

Migrate from the deprecated middleware.ts file convention to the new proxy.ts convention as required by Next.js 16.0.10.

The middleware file convention has been deprecated and renamed to 'proxy' to better clarify its purpose as a network boundary in front of the app, and to avoid confusion with Express.js middleware.

Changes:

Rename apps/site/middleware.ts to apps/site/proxy.ts
Add named export const proxy = createMiddleware({
Maintain full compatibility with next-intl internationalization
Update comments to reflect proxy terminology

This resolves the deprecation warning:
'The middleware file convention is deprecated. Please use proxy instead.'

Refs: https://nextjs.org/docs/messages/middleware-to-proxy

Description

Validation

Related Issues

Fixed #8418

Check List

I have read the Contributing Guidelines and made commit messages that follow the guideline.
I have run pnpm format to ensure the code follows the style guide.
I have run pnpm test to check if all tests are passing.
I have run pnpm build to check if the website builds without errors.
I've covered new added functionality with unit tests if necessary.

vercel · 2025-12-14T14:00:52Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Review	Updated (UTC)
nodejs-org	Ready	Preview	Dec 31, 2025 2:49pm

github-actions · 2025-12-14T14:00:57Z

👋 Codeowner Review Request

The following codeowners have been identified for the changed files:

Team reviewers: @nodejs/nodejs-website

Please review the changes when you have a chance. Thank you! 🙏

avivkeller

export const proxy = createMiddleware({

You should just be able to do this, no?

Faizanahmedsy · 2025-12-14T14:08:07Z

export const proxy = createMiddleware({
You should just be able to do this, no?

I have done as per documentation, but let me try if this similer approch works

…ility Migrate from the deprecated middleware.ts file convention to the new proxy.ts convention as required by Next.js 16.0.10. The middleware file convention has been deprecated and renamed to 'proxy' to better clarify its purpose as a network boundary in front of the app, and to avoid confusion with Express.js middleware. Changes: - Rename apps/site/middleware.ts to apps/site/proxy.ts - Add named export function 'proxy' instead of default export - Add NextRequest type import for type safety - Maintain full compatibility with next-intl internationalization - Update comments to reflect proxy terminology This resolves the deprecation warning: 'The middleware file convention is deprecated. Please use proxy instead.' Refs: https://nextjs.org/docs/messages/middleware-to-proxy

MattIPv4

The reference to this file in CODEOWNERS needs updating, please

Faizanahmedsy · 2025-12-14T14:17:06Z

hi @avivkeller I amended the commit to incorporate this feedback. I've verified that both approaches work correctly, and all tests pass

apps/site/proxy.ts

Faizanahmedsy · 2025-12-14T14:22:40Z

The reference to this file in CODEOWNERS needs updating, please

okay checking that

Faizanahmedsy · 2025-12-14T14:25:07Z

The reference to this file in CODEOWNERS needs updating, please

hi @MattIPv4 I have done that please check if I have done it correctly or not

- apps/site/middleware.ts @nodejs/web-infra
+ apps/site/proxy.ts @nodejs/web-infra

avivkeller · 2025-12-14T14:34:43Z

The added comment is still not needed, you only removed half of it.

Faizanahmedsy · 2025-12-14T14:39:38Z

The added comment is still not needed, you only removed half of it.

yeah sorry about that check now f4507a8

ovflowd

We aren't using the new middleware because it's not compatible with OpenNext. That was intentional. Blocking changes.

opennextjs/opennextjs-cloudflare#972

avivkeller

Looks like Matt and Claudio still have ~~concerns~~ blockers, but LGTM regarding my previous blockers

ovflowd · 2025-12-14T14:54:52Z

Looks like Matt and Claudio still have concerns, but LGTM with my blockers

Not concerns. This actually cannot be merged, otherwise it breaks Cloudflare builds.

ovflowd · 2025-12-14T15:10:53Z

To be clear not against the changes, just, they cannot be merged meantime.

Faizanahmedsy · 2025-12-15T00:22:36Z

To be clear not against the changes, just, they cannot be merged meantime.

Okay 👍, I will try to remind you once Open Next Supports it

ovflowd · 2025-12-15T00:32:45Z

Thank you! You can keep the PR open although I'd recommend converting it back to a draft state.

avivkeller

The file content is wrong, actually, we should still be exporting default, per the ~~next-i18n~~ next-intl docs

MattIPv4 · 2025-12-30T15:45:00Z

🤔 Are we sure the next-i18n docs are correct there? Given the proxy is a Next.js feature, I'd be included to follow the Next.js docs, not third-party docs... (I suspect a default export is supported for backwards compat alongside the named export Next.js wants folks to use now).

avivkeller · 2025-12-30T16:17:31Z

(I suspect a default export is supported for backwards compat alongside the named export Next.js wants folks to use now).

https://nextjs.org/docs/app/getting-started/proxy#example states "You can export your proxy function as either a default export or a named proxy export". IMO if the next-intl docs want the default, we should do it

Faizanahmedsy · 2025-12-31T14:49:03Z

HI @MattIPv4 @avivkeller Can you please check now

ovflowd · 2025-12-31T15:09:08Z

I mean looks fine, but has opennext actually implemented support to proxy.ts yet?

ovflowd · 2025-12-31T15:09:33Z

apps/site/proxy.ts

 import { availableLocaleCodes, defaultLocale } from '#site/next.locales.mjs';

-export default createMiddleware({
+export const proxy = createMiddleware({


Suggested change

export const proxy = createMiddleware({

export default createMiddleware({

Just leave as it was 😅

Faizanahmedsy requested review from a team as code owners December 14, 2025 14:00

vercel bot deployed to Preview December 14, 2025 14:02 View deployment

avivkeller requested changes Dec 14, 2025

View reviewed changes

Faizanahmedsy force-pushed the chore/migrate-to-proxy branch from 62fb290 to 79378b7 Compare December 14, 2025 14:10

vercel bot deployed to Preview December 14, 2025 14:11 View deployment

MattIPv4 requested changes Dec 14, 2025

View reviewed changes

avivkeller reviewed Dec 14, 2025

View reviewed changes

apps/site/proxy.ts Outdated Show resolved Hide resolved

refactor: removed unnecessary comment

3443dc6

vercel bot deployed to Preview December 14, 2025 14:20 View deployment

chore: update CODEOWNERS to reference proxy.ts instead of middleware.ts

1e4b333

vercel bot deployed to Preview December 14, 2025 14:25 View deployment

refactor: removed proxy realted comments

f4507a8

vercel bot deployed to Preview December 14, 2025 14:36 View deployment

ovflowd requested changes Dec 14, 2025

View reviewed changes

avivkeller approved these changes Dec 14, 2025

View reviewed changes

avivkeller added the blocked label Dec 20, 2025

bjohansebas approved these changes Dec 20, 2025

View reviewed changes

avivkeller requested changes Dec 30, 2025

View reviewed changes

Faizanahmedsy added 2 commits December 31, 2025 20:16

refactor: changed to default export

9dd2dbe

removed comment

fda06ad

vercel bot deployed to Preview December 31, 2025 14:49 View deployment

ovflowd reviewed Dec 31, 2025

View reviewed changes

	export const proxy = createMiddleware({
	export default createMiddleware({

Uh oh!

Conversation

Faizanahmedsy commented Dec 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Validation

Related Issues

Check List

Uh oh!

vercel bot commented Dec 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Dec 14, 2025

👋 Codeowner Review Request

Uh oh!

avivkeller left a comment

Choose a reason for hiding this comment

Uh oh!

Faizanahmedsy commented Dec 14, 2025

Uh oh!

MattIPv4 left a comment

Choose a reason for hiding this comment

Uh oh!

Faizanahmedsy commented Dec 14, 2025

Uh oh!

Uh oh!

Faizanahmedsy commented Dec 14, 2025

Uh oh!

Faizanahmedsy commented Dec 14, 2025

Uh oh!

avivkeller commented Dec 14, 2025

Uh oh!

Faizanahmedsy commented Dec 14, 2025

Uh oh!

ovflowd left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

avivkeller left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ovflowd commented Dec 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ovflowd commented Dec 14, 2025

Uh oh!

Faizanahmedsy commented Dec 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ovflowd commented Dec 15, 2025

Uh oh!

avivkeller left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MattIPv4 commented Dec 30, 2025

Uh oh!

avivkeller commented Dec 30, 2025

Uh oh!

Faizanahmedsy commented Dec 31, 2025

Uh oh!

ovflowd commented Dec 31, 2025

Uh oh!

ovflowd Dec 31, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Faizanahmedsy commented Dec 14, 2025 •

edited

Loading

vercel bot commented Dec 14, 2025 •

edited

Loading

ovflowd left a comment •

edited

Loading

avivkeller left a comment •

edited

Loading

ovflowd commented Dec 14, 2025 •

edited

Loading

Faizanahmedsy commented Dec 15, 2025 •

edited

Loading

avivkeller left a comment •

edited

Loading