Open
Conversation
Open
# Conflicts: # src/interactions/brush.js # test/plots/brush.ts
Draft
allisonhorst
left a comment
allisonhorst
left a comment
There was a problem hiding this comment.
If tooltip is already visible (hovering near a point) and I start brushing, that last tooltip remains visible. I expected the tooltip to disappear as soon as I start brushing. Clicking after brushing removes the lingering tooltip, and I'm able to hover to show the tooltip again. I would expect to be able to see the tooltip on hover immediately after I release the brush, without requiring the additional click.
brush-tip-plot.mp4
Contributor
Author
|
I think the new version fixes the behavior, at least it now feels a bit more natural to me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using a simple signalling through a className on the svg, we disable the tip interaction during brushing.