Fix AttributeError on Python 3.9 when invalid type passed to attributes#4933
Closed
thakoreh wants to merge 2 commits intoopen-telemetry:mainfrom
Closed
Fix AttributeError on Python 3.9 when invalid type passed to attributes#4933thakoreh wants to merge 2 commits intoopen-telemetry:mainfrom
thakoreh wants to merge 2 commits intoopen-telemetry:mainfrom
Conversation
Add _get_type_name helper to handle typing module types that don't have __name__ attribute on Python 3.9 (like Sequence, Mapping). Fixes: open-telemetry#4821
Author
|
The CI is failing because no CHANGELOG entry was added. You can either:
This looks like a bug fix, so a changelog entry would be appropriate. |
Contributor
|
@thakoreh we already have two open PRs for this, we don't need more 😅 |
github-project-automation
bot
moved this from Ready for review
to Done
in @xrmx's Python PR digest
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes issue #4821 - Incorrect error when passing wrong attribute type on Python 3.9
The issue is that on Python 3.9, and don't have attribute, which causes an instead of the expected when an invalid type is passed.
Changes
Root Cause
The fix uses and falls back to or for typing module types.
Test
The fix can be verified by running:
Before fix:
After fix: