Open
Conversation
Contributor
WalkthroughThe changes introduce a new smoke trail particle effect system for missiles, integrate it into the FX rendering layer to handle specific missile unit types (AtomBomb, HydrogenBomb, MIRV, MIRVWarhead, SAMMissile), and refactor coordinate handling in unit interactions to avoid mutating input parameters. Changes
Sequence DiagramsequenceDiagram
participant Unit as Unit Activation
participant FxLayer as FX Layer
participant SmokeTrail as SmokeTrailFx
participant Canvas as Canvas Render
Unit->>FxLayer: Unit activated (missile type)
FxLayer->>SmokeTrail: Create SmokeTrailFx(game, unitId)
FxLayer->>FxLayer: Store in missileTrails map
loop Each Render Frame
FxLayer->>SmokeTrail: renderTick(duration, ctx)
SmokeTrail->>SmokeTrail: Emit new particle if active
SmokeTrail->>SmokeTrail: Update all particles (position, size, color)
SmokeTrail->>Canvas: Draw particles to context
SmokeTrail->>FxLayer: Return active status
alt Effect Complete
FxLayer->>FxLayer: Remove from missileTrails
end
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. 📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
ryanbarlow97
requested changes
Mar 14, 2026
Comment on lines
+130
to
157
| let targetRef = clickRef; | ||
| if (targetRef === undefined) { | ||
| // Convert screen coordinates to world coordinates | ||
| const cell = this.transformHandler.screenToWorldCoordinates( | ||
| event.x, | ||
| event.y, | ||
| ); | ||
| if (!this.game.isValidCoord(cell.x, cell.y)) return; | ||
|
|
||
| clickRef = this.game.ref(cell.x, cell.y); | ||
| targetRef = this.game.ref(cell.x, cell.y); | ||
| } | ||
| if (!this.game.isOcean(clickRef)) return; | ||
| if (!this.game.isOcean(targetRef)) return; | ||
|
|
||
| if (this.selectedUnit) { | ||
| this.eventBus.emit( | ||
| new MoveWarshipIntentEvent(this.selectedUnit.id(), clickRef), | ||
| new MoveWarshipIntentEvent(this.selectedUnit.id(), targetRef), | ||
| ); | ||
| // Deselect | ||
| this.eventBus.emit(new UnitSelectionEvent(this.selectedUnit, false)); | ||
| return; | ||
| } | ||
|
|
||
| // Find warships near this tile, sorted by distance | ||
| nearbyWarships ??= this.findWarshipsNearCell(clickRef); | ||
| if (nearbyWarships.length > 0) { | ||
| const warships = nearbyWarships ?? this.findWarshipsNearCell(targetRef); | ||
| if (warships.length > 0) { | ||
| // Toggle selection of the closest warship | ||
| this.eventBus.emit(new UnitSelectionEvent(nearbyWarships[0], true)); | ||
| this.eventBus.emit(new UnitSelectionEvent(warships[0], true)); | ||
| } |
github-project-automation
bot
moved this from Triage
to Development
in OpenFront Release Management
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: Added smoke trails to nukes for cooler in flight nuke animation, also put smoke trails under the special effects setting. When the player enables special effects setting then smoke trails is also enabled. When special effects is disabled then smoke trails is also disabled.
Please complete the following:
Please put your Discord username so you can be contacted if a bug or regression is found:
Restart