Skip to content

feat(ent): add tax_code_id foreign keys across billing, subscription and rate card schemas#3926

Draft
borbelyr-kong wants to merge 1 commit intomainfrom
feat/tax-codes-v3-migrations
Draft

feat(ent): add tax_code_id foreign keys across billing, subscription and rate card schemas#3926
borbelyr-kong wants to merge 1 commit intomainfrom
feat/tax-codes-v3-migrations

Conversation

@borbelyr-kong
Copy link
Contributor

No description provided.

@borbelyr-kong borbelyr-kong added the release-note/ignore Ignore this change when generating release notes label Mar 5, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 5, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 7b37e3b1-9593-4150-a722-ac4080631f1a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/tax-codes-v3-migrations

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Ref("addon_ratecard").
Field("feature_id").
Unique(),
edge.From("tax_code", TaxCode.Type).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please get rid of the TaxConfig jsonb prop and normalize behavior to another property as well

*: get rid of is a two step process, don't actually get rid of that here just add the new field & prepare the migration that drops it (later)

@borbelyr-kong borbelyr-kong force-pushed the feat/tax-codes-v3-migrations branch from 187554a to 5031e95 Compare March 11, 2026 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-note/ignore Ignore this change when generating release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants