Conversation
|
This is not the final version of the PR, I want to know your first draft review. |
sepandhaghighi
left a comment
sepandhaghighi
left a comment
There was a problem hiding this comment.
@AHReccese Thank you for your hard work! 🚀
The main approach looks good overall. I have a basic suggestion regarding the naming of the adapters, as we plan to support three different types. I recommend using clearer names for better understanding:
- Change
IPv4HTTPAdaptertoIPv4TransportAdapter - Change
IPv6HTTPAdaptertoIPv6TransportAdapter IPv4HostHeaderAdapter(Next version)IPv6HostHeaderAdapter(Next version)
These names are just suggestions. If you have better names in mind, feel free to use them.
|
Thank you Sepand for your feedback, I've applied your it. Let me know if you have any other suggestions. |
|
@AHReccese Update the adapter functionality to use the approach implemented here: openscilab/ipspot#77 |
…ution, removing init_poolmanager and socket options methods
…during send, cleanup after send, and restoration of socket.getaddrinfo on exceptions
…hon actions' version
…s + remove token (since the repo is going to be public)
AHReccese
force-pushed
the
add/adapters
branch
from
d540990 to
5c07f94
Compare
|
@sepandhaghighi Could you please take a look at this? not finalized yet, but I wanted to have your thoughts on this. |
sepandhaghighi
left a comment
sepandhaghighi
left a comment
There was a problem hiding this comment.
@AHReccese Thanks for your efforts 💯
Please take a look at my comments 🥇
2 participants
IPv6HTTPAdapteradapterIPv4HTTPAdapteradapter